Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(motion_utils): faster removeOverlapPoints and calcLateralOffset functions (awf#5385) #1066

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

Owen-Liuyuxuan
Copy link

Description

Related PR: autowarefoundation#5385

Improve memory allocation strategy for removeOverlapPoints to improve speed and stability.

Tests performed

INTERNAL CI Test failed in remote before now passed locally

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit 4ccdea8 into beta/v0.10.6 Dec 11, 2023
11 checks passed
@shmpwk shmpwk deleted the perf/faster_removeOverlapPoints/0.10.6 branch December 11, 2023 09:03
satoshi-ota pushed a commit that referenced this pull request Jan 15, 2024
…functions (awf#5385) (#1066)

* faster removeOverlapPoints and calcLateralOffset functions

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants