Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_stop): upd obstacle hunting #1068

Merged
merged 20 commits into from
Dec 19, 2023

Conversation

sfukuta
Copy link

@sfukuta sfukuta commented Dec 12, 2023

このPRはv0.3.17リリース向けに開発していたもののドロップしたPR #733 を、v0.3.18リリース向けに適用し直すためのPRです。

Description

本PRは下記問題を対策する。

  • 問題A
    • 経路上の障害物を検知した状態で自車両に対して前後方向に検知位置が振動する挙動があり、これにあわせて車両が停車と発車を交互に繰り返す(チャタリングする)。
    • 音声発話として、停車と発車も繰り返す
  • 問題B
    • 経路上に複数の障害物を検知した場合、停止線が異常な位置に設定される

対策内容

image

Related links

https://tier4.atlassian.net/browse/AEAP-465
https://github.com/tier4/autoware_launch.x1.eve/pull/419

Tests performed

機能検証

chattering_thresholdの設定値を、default値では機能検証が難しいため、5sに変更して確認を実施。

  • 障害物を経路上に設定、障害物検知し停車後に、障害物がなくなっても、即時に再発進しない事を確認済み(Psim)
  • 一定時間(chattering_thresholで設定した時間)停止後に、再発車する事を確認済み(Psim)
  • 経路上に障害物を、2つ設置し、2点間でチャタリングをしない事を確認済み(Psim)

機能追加検証

  • 停車時に、障害物を経路上にセットした後に、障害物除去後に、5s(chattering_thresholdの設定値)に障害物停止線が消える事を確認。(Psim)
  • 走行中に、障害物を経路上にセットした後に、障害物除去後に、即時に障害物停止線が消える事を確認。(Psim)

リグレッション評価

  • 経路上に障害物がない場合に、停車しないで走行が完了する事を確認済み。(Psim)
  • 経路上に障害物がある場合に、障害物検知時に、停止線で停止する事。障害物除去後に、再発車できる事を確認済み(Psim)
  • 走行中の経路上に障害物を設置と除去を一瞬で実施した場合、障害物検知状態は一瞬だけで実施されて、障害物検知状態を維持しない事を確認済み(Psim)

809b85e の確認

前提条件:chattering_thresholdのパラメーター値:5.0s

Psimの確認内容:

  • 障害物除去後に、停止中の障害物停止線が、一定時間後(約5.0s)にクリアされる事を確認済み。
  • 障害物除去後に、走行中の障害物停止線が、走行中に即時クリアされる事を確認済み。

Rview Note

  • 音声チャタリングの評価は、リリース評価で実施する。

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@sfukuta
Copy link
Author

sfukuta commented Dec 19, 2023

@yn-mrse 809b85e

  • 走行中の障害物検知をした場合に、停止するまで障害物停止線が消えない問題を対応
  • Psimにて、停止状態でも、即時に障害物停止線クリアされる現象を確認し、停止条件の閾値を、1e-9から0.001に変更

前提条件:chattering_thresholdのパラメーター値:5.0s

Psimの確認内容:

  • 障害物除去後に、停止中の障害物停止線が、一定時間後(約5.0s)にクリアされる事を確認済み。
  • 障害物除去後に、走行中の障害物停止線が、走行中に即時クリアされる事を確認済み。

Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ソースコードを確認しましたが、Descriptionに記載の内容と合致していることから変更内容は妥当であると思われます。
  • テスト内容としても、PSim及び実車にて妥当な試験が実施されており、それらをパスしているため問題ないと判断しています。

@sfukuta sfukuta merged commit 65e903c into beta/v0.3.18 Dec 19, 2023
14 of 16 checks passed
@sfukuta sfukuta deleted the feat/planning/upd_obstacle_hunting branch December 19, 2023 05:02
asa-naki pushed a commit that referenced this pull request Sep 17, 2024
* Adapted from PR #1458

Signed-off-by: Shigekazu Fukuta <[email protected]>

* Adapted from PR #1627

Signed-off-by: Shigekazu Fukuta <[email protected]>

* fix parameter name

Signed-off-by: Shigekazu Fukuta <[email protected]>

* Adapted from PR autowarefoundation#2647

Signed-off-by: Shigekazu Fukuta <[email protected]>

* ci(pre-commit): autofix

* fix build error

* ci(pre-commit): autofix

* remove comment line

* remove logic

* Delete parameters other than those added this time

* ci(pre-commit): autofix

* add stop vehicle check

* ci(pre-commit): autofix

* fix stop velocity threshold

* fix engage obstacle clear and stop threshold

* ci(pre-commit): autofix

---------

Signed-off-by: Shigekazu Fukuta <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@sfukuta sfukuta mentioned this pull request Sep 18, 2024
asa-naki added a commit that referenced this pull request Sep 18, 2024
asa-naki added a commit that referenced this pull request Sep 18, 2024
* fix(system_monitor): extend command line to display (backport autowarefoundation#4553) (#768)

fix(system_monitor): extend command line to display (autowarefoundation#4553)

Signed-off-by: ito-san <[email protected]>
Co-authored-by: ito-san <[email protected]>

* feat(behavior_path_planner): resample output path (backport #1604) (#782)

feat(behavior_path_planner): resample output path (#1604)

* feat(behavior_path_planner): resample output path



* update param

Signed-off-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>

* ci: add dispatch-push-event workflow  (#803)

* ci: add dispatch-push-event workflow

Signed-off-by: Keisuke Shima <[email protected]>

* fix: change APP KEY

Signed-off-by: Keisuke Shima <[email protected]>

* chore: use strategy

Signed-off-by: Keisuke Shima <[email protected]>

* chore: change trigger

Signed-off-by: Keisuke Shima <[email protected]>

* pre-commit fixes

Signed-off-by: Keisuke Shima <[email protected]>

* Update .github/workflows/dispatch-push-event.yaml

* Update .github/workflows/dispatch-push-event.yaml

* style(pre-commit): autofix

* Update .github/workflows/dispatch-push-event.yaml

---------

Signed-off-by: Keisuke Shima <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)

* fix(behavior_path): only apply spline interpolate for output, not for turn_signal processing

* fix implementation

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(behavior_path): fix base points vanishing and inconsistent lane_ids on the spline interpolated path (#929)

* add base points to resampled path in behavior_path

* Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)"

This reverts commit c80c986.

* ci(pre-commit): autofix

* fix insert

* fix: not interpolate behavior velocity path

* Revert "Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)""

This reverts commit e6dd540.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(system_monitor): fix program command line reading (backport autowarefoundation#5191, autowarefoundation#5430) (#995)

* perf(system_monitor): fix program command line reading (autowarefoundation#5191)

* Fix program command line reading

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* fix spelling commandline->command_line

Signed-off-by: Owen-Liuyuxuan <[email protected]>

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(system_monitor): output command line (autowarefoundation#5430)

* fix(system_monitor): output command line

Signed-off-by: takeshi.iwanari <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: takeshi.iwanari <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: takeshi.iwanari <[email protected]>
Co-authored-by: Yuxuan Liu <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: takeshi-iwanari <[email protected]>
Co-authored-by: Akihisa Nagata <[email protected]>

* feat(obstacle_stop): upd obstacle hunting (#1068)

* Adapted from PR #1458

Signed-off-by: Shigekazu Fukuta <[email protected]>

* Adapted from PR #1627

Signed-off-by: Shigekazu Fukuta <[email protected]>

* fix parameter name

Signed-off-by: Shigekazu Fukuta <[email protected]>

* Adapted from PR autowarefoundation#2647

Signed-off-by: Shigekazu Fukuta <[email protected]>

* ci(pre-commit): autofix

* fix build error

* ci(pre-commit): autofix

* remove comment line

* remove logic

* Delete parameters other than those added this time

* ci(pre-commit): autofix

* add stop vehicle check

* ci(pre-commit): autofix

* fix stop velocity threshold

* fix engage obstacle clear and stop threshold

* ci(pre-commit): autofix

---------

Signed-off-by: Shigekazu Fukuta <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(obstacle_avoidance_planner): add empty check (#1285)

* fix(obstacle_avoidance_planner): add empty check

* ci(pre-commit): autofix

* add invalid_argument

* delete empty check

* return code moved to end

* add warning log

* update rclcpp_debug

* delete debug log

* Delete unnecessary blank lines

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(virtual traffic light): suppress lauch (#1290)

* suppress launch

Signed-off-by: Yuki Takagi <[email protected]>

* add existence check

Signed-off-by: Yuki Takagi <[email protected]>

---------

Signed-off-by: Yuki Takagi <[email protected]>
Co-authored-by: Shigekazu Fukuta <[email protected]>

* revert: #929,#909,#782

* revert: #1068
- d56c191.

---------

Signed-off-by: ito-san <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: takeshi.iwanari <[email protected]>
Signed-off-by: Shigekazu Fukuta <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: ito-san <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yuxuan Liu <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: takeshi-iwanari <[email protected]>
Co-authored-by: Shigekazu Fukuta <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants