forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_stop): upd obstacle hunting #1068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shigekazu Fukuta <[email protected]>
Signed-off-by: Shigekazu Fukuta <[email protected]>
Signed-off-by: Shigekazu Fukuta <[email protected]>
Signed-off-by: Shigekazu Fukuta <[email protected]>
yn-mrse
requested changes
Dec 14, 2023
yn-mrse
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ソースコードを確認しましたが、Descriptionに記載の内容と合致していることから変更内容は妥当であると思われます。
- テスト内容としても、PSim及び実車にて妥当な試験が実施されており、それらをパスしているため問題ないと判断しています。
asa-naki
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Adapted from PR #1458 Signed-off-by: Shigekazu Fukuta <[email protected]> * Adapted from PR #1627 Signed-off-by: Shigekazu Fukuta <[email protected]> * fix parameter name Signed-off-by: Shigekazu Fukuta <[email protected]> * Adapted from PR autowarefoundation#2647 Signed-off-by: Shigekazu Fukuta <[email protected]> * ci(pre-commit): autofix * fix build error * ci(pre-commit): autofix * remove comment line * remove logic * Delete parameters other than those added this time * ci(pre-commit): autofix * add stop vehicle check * ci(pre-commit): autofix * fix stop velocity threshold * fix engage obstacle clear and stop threshold * ci(pre-commit): autofix --------- Signed-off-by: Shigekazu Fukuta <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
asa-naki
added a commit
that referenced
this pull request
Sep 18, 2024
* fix(system_monitor): extend command line to display (backport autowarefoundation#4553) (#768) fix(system_monitor): extend command line to display (autowarefoundation#4553) Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]> * feat(behavior_path_planner): resample output path (backport #1604) (#782) feat(behavior_path_planner): resample output path (#1604) * feat(behavior_path_planner): resample output path * update param Signed-off-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> * ci: add dispatch-push-event workflow (#803) * ci: add dispatch-push-event workflow Signed-off-by: Keisuke Shima <[email protected]> * fix: change APP KEY Signed-off-by: Keisuke Shima <[email protected]> * chore: use strategy Signed-off-by: Keisuke Shima <[email protected]> * chore: change trigger Signed-off-by: Keisuke Shima <[email protected]> * pre-commit fixes Signed-off-by: Keisuke Shima <[email protected]> * Update .github/workflows/dispatch-push-event.yaml * Update .github/workflows/dispatch-push-event.yaml * style(pre-commit): autofix * Update .github/workflows/dispatch-push-event.yaml --------- Signed-off-by: Keisuke Shima <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909) * fix(behavior_path): only apply spline interpolate for output, not for turn_signal processing * fix implementation * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(behavior_path): fix base points vanishing and inconsistent lane_ids on the spline interpolated path (#929) * add base points to resampled path in behavior_path * Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)" This reverts commit c80c986. * ci(pre-commit): autofix * fix insert * fix: not interpolate behavior velocity path * Revert "Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)"" This reverts commit e6dd540. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(system_monitor): fix program command line reading (backport autowarefoundation#5191, autowarefoundation#5430) (#995) * perf(system_monitor): fix program command line reading (autowarefoundation#5191) * Fix program command line reading Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix * fix spelling commandline->command_line Signed-off-by: Owen-Liuyuxuan <[email protected]> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(system_monitor): output command line (autowarefoundation#5430) * fix(system_monitor): output command line Signed-off-by: takeshi.iwanari <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: Yuxuan Liu <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: Akihisa Nagata <[email protected]> * feat(obstacle_stop): upd obstacle hunting (#1068) * Adapted from PR #1458 Signed-off-by: Shigekazu Fukuta <[email protected]> * Adapted from PR #1627 Signed-off-by: Shigekazu Fukuta <[email protected]> * fix parameter name Signed-off-by: Shigekazu Fukuta <[email protected]> * Adapted from PR autowarefoundation#2647 Signed-off-by: Shigekazu Fukuta <[email protected]> * ci(pre-commit): autofix * fix build error * ci(pre-commit): autofix * remove comment line * remove logic * Delete parameters other than those added this time * ci(pre-commit): autofix * add stop vehicle check * ci(pre-commit): autofix * fix stop velocity threshold * fix engage obstacle clear and stop threshold * ci(pre-commit): autofix --------- Signed-off-by: Shigekazu Fukuta <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(obstacle_avoidance_planner): add empty check (#1285) * fix(obstacle_avoidance_planner): add empty check * ci(pre-commit): autofix * add invalid_argument * delete empty check * return code moved to end * add warning log * update rclcpp_debug * delete debug log * Delete unnecessary blank lines --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(virtual traffic light): suppress lauch (#1290) * suppress launch Signed-off-by: Yuki Takagi <[email protected]> * add existence check Signed-off-by: Yuki Takagi <[email protected]> --------- Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Shigekazu Fukuta <[email protected]> * revert: #929,#909,#782 * revert: #1068 - d56c191. --------- Signed-off-by: ito-san <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Keisuke Shima <[email protected]> Signed-off-by: Owen-Liuyuxuan <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Signed-off-by: Shigekazu Fukuta <[email protected]> Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: ito-san <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yuxuan Liu <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: Shigekazu Fukuta <[email protected]> Co-authored-by: Yuki TAKAGI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このPRはv0.3.17リリース向けに開発していたもののドロップしたPR #733 を、v0.3.18リリース向けに適用し直すためのPRです。
Description
本PRは下記問題を対策する。
対策内容
これにより、障害物の移動によるチャタリングを回避する。
chattering_threshold
で設定する。(defalut : 0.5s)/localization/kinematic_state
のtwist.twist.linear.x
より判定を実施する。twist.twist.linear.x=0
の場合を停車、それ以外を走行中としています。twist.twist.linear.x<0
は、考慮不要です。Related links
https://tier4.atlassian.net/browse/AEAP-465
https://github.com/tier4/autoware_launch.x1.eve/pull/419
Tests performed
機能検証
chattering_threshold
の設定値を、default値では機能検証が難しいため、5sに変更して確認を実施。chattering_threshol
で設定した時間)停止後に、再発車する事を確認済み(Psim)機能追加検証
chattering_threshold
の設定値)に障害物停止線が消える事を確認。(Psim)リグレッション評価
809b85e の確認
前提条件:chattering_thresholdのパラメーター値:5.0s
Psimの確認内容:
Rview Note
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.