refactor(motion_utils): cherry picked from a merged PR #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies (autowarefoundation#5909) * change .hpp name Signed-off-by: Zhe Shen <[email protected]> * change .cpp name Signed-off-by: Zhe Shen <[email protected]> * correct the #inlcude and #ifndef Signed-off-by: Zhe Shen <[email protected]> * toPath(): move the prototypes and the implementations in .hpp and .cpp Signed-off-by: Zhe Shen <[email protected]> * correct the dependency for /home/shen/autoware.universe/planning/behavior_path_planner/src/behavior_path_planner_node.cpp Signed-off-by: Zhe Shen <[email protected]> * toPath(): deleted the repeat definition in planning_interface_test_manager_utils.hpp Signed-off-by: Zhe Shen <[email protected]> * toPath(): corrected the call and dependency in planning_interface_test_manager.cpp Signed-off-by: Zhe Shen <[email protected]> * convertPathToTrajectoryPoints(), convertTrajectoryPointsToPath(), lerpOrientation(): moved to conversion.hpp and conversion.cpp Signed-off-by: Zhe Shen <[email protected]> * convertPathToTrajectoryPoints(): corrected the call and dependency Signed-off-by: Zhe Shen <[email protected]> * convertTrajectoryPointsToPath(): Corrected the call Signed-off-by: Zhe Shen <[email protected]> * lerpOrientation(): deleted the repeat definition in longitudinal_controller_utils.hpp and longitudinal_controller_utils.cpp Signed-off-by: Zhe Shen <[email protected]> * lerpOrientation(): Correct the call in longitudinal_controller_utils.hpp Signed-off-by: Zhe Shen <[email protected]> * lerpOrientation(): Corrected the dependency and call in test_longitudinal_controller_utils.cpp Signed-off-by: Zhe Shen <[email protected]> * name of conversion.cpp: modified the CMakeLists Signed-off-by: Zhe Shen <[email protected]> * namespace updated, but maybe not correct, will be tested in the next commit Signed-off-by: Zhe Shen <[email protected]> * Correct the dependencies the test_trajectory.cpp and test_interpolation.cpp Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * [namespace problems fixed] conversion.cpp & conversion.hpp: The dependencies have been added. Also, the namespaces have been corrected. Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * correct all the dependencies in #include Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * avoid using the ../../ in the paths Signed-off-by: Zhe Shen <[email protected]> * dependencies fixed and package added in .xml Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * change toPath() to convertToPath() Signed-off-by: Zhe Shen <[email protected]> * lerpOrientation(): move from conversion to spherical_linear_interpolation Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * fix the missing relative path definition. ../../ will not be used. Signed-off-by: Zhe Shen <[email protected]> * the unneccessary dependencies eleminated. In specific, the lerpOrientation() related dependencies in coversion.hpp and unneccessary dependencies in conversion.cpp are deleted. Signed-off-by: Zhe Shen <[email protected]> * change the function to template in .cpp and .hpp Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * change the corresponding calls to template Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * change name to convertToTrajectory() Signed-off-by: Zhe Shen <[email protected]> * style(pre-commit): autofix * change the template of convertToPathWithLaneId() Signed-off-by: Zhe Shen <[email protected]> * fix the dependencies Signed-off-by: Zhe Shen <[email protected]> * refactor(motion_utils): specialize class Signed-off-by: satoshi-ota <[email protected]> * fix(motion_utils): remove unnecessary header Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]> Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi OTA <[email protected]> Co-authored-by: satoshi-ota <[email protected]>
HansOersted
requested review from
kyoichi-sugahara,
TakaHoribe,
rej55,
isamu-takagi,
soblin,
shmpwk,
tkimura4,
danielsanchezaran,
kosuke55,
maxime-clem,
satoshi-ota,
takayuki5168,
zulfaqar-azmi-t4,
TomohitoAndo and
taikitanaka3
as code owners
kyoichi-sugahara
approved these changes
Jan 11, 2024
shmpwk
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autowarefoundation#5909
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.