Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enable_all_modules_auto_mode argument to launch files for behavior modules #1112

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Jan 23, 2024

Description

autowarefoundation#6093
autowarefoundation#6094

auto_mode is controlled by parameter of enable_rtc
(Related PR: https://github.com/tier4/autoware_launch.xx1/pull/747 )

Tests performed

See https://github.com/tier4/autoware_launch.xx1/pull/747 (TIERIV Internal Link)

Effects on system behavior

Not applicable (no effects when using default parameters).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…t to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <[email protected]>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
…ument to launch files for behavior velocity planner modules (autowarefoundation#6094)

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <[email protected]>

* Refactor scene module managers to use getEnableRTC function

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

@tkimura4 tkimura4 merged commit 085dfca into beta/v0.20.1 Jan 23, 2024
16 checks passed
@tkimura4 tkimura4 deleted the feat/add_enable_all_auto_mode branch January 23, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants