feat(perception): refactor pointcloud container #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utowarefoundation#6091) * feat!: replace use_pointcloud_container Signed-off-by: kminoda <[email protected]> * feat: remove from planning Signed-off-by: kminoda <[email protected]> * fix: fix to remove all use_pointcloud_container Signed-off-by: kminoda <[email protected]> * revert: revert change in planning.launch Signed-off-by: kminoda <[email protected]> * revert: revert rename of use_pointcloud_container Signed-off-by: kminoda <[email protected]> * fix: fix tier4_perception_launch to enable use_pointcloud_contaienr Signed-off-by: kminoda <[email protected]> * fix: fix unnecessary change Signed-off-by: kminoda <[email protected]> * fix: fix unnecessary change Signed-off-by: kminoda <[email protected]> * refactor: remove trailing whitespace Signed-off-by: kminoda <[email protected]> * revert other changes in perception Signed-off-by: kminoda <[email protected]> * revert change in readme Signed-off-by: kminoda <[email protected]> * feat: move glog to pointcloud_container.launch.py * revert: revert glog porting Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: fix pre-commit Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion launcher (autowarefoundation#6152) * refactor: align mode parameters Signed-off-by: Taekjin LEE <[email protected]> * refactor: cluster detector and merger Signed-off-by: Taekjin LEE <[email protected]> * refactor: separate object merger launches Signed-off-by: Taekjin LEE <[email protected]> * refactor: radar detector module Signed-off-by: Taekjin LEE <[email protected]> * refactor: lidar detector modules Signed-off-by: Taekjin LEE <[email protected]> * chore: fix mis spell, align typo, clean-up Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
* feat(lidar_centerpoint,image_projection_based_fusion): add pointcloud_container option Signed-off-by: kminoda <[email protected]> * revert lidar_perception_model Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: add options Signed-off-by: kminoda <[email protected]> * fix: fix default param Signed-off-by: kminoda <[email protected]> * update node name Signed-off-by: kminoda <[email protected]> * fix: fix IfCondition Signed-off-by: kminoda <[email protected]> * fix pointpainting namespace Signed-off-by: kminoda <[email protected]> * fix: fix launch args Signed-off-by: kminoda <[email protected]> * fix(euclidean_cluster): do not launch individual container when use_pointcloud_container is true Signed-off-by: kminoda <[email protected]> * fix(euclidean_cluster): fix launch condition Signed-off-by: kminoda <[email protected]> * fix(euclidean_cluster): fix launch condition Signed-off-by: kminoda <[email protected]> * Update perception/lidar_centerpoint/launch/lidar_centerpoint.launch.xml Co-authored-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
github-actions
bot
added
type:documentation
component:launch
component:perception
labels
kminoda
changed the title
kminoda
requested review from
soblin,
YoshiRi,
yukkysaito,
knzo25,
badai-nguyen,
ktro2828,
miursh,
tzhong518,
KYabuuchi,
RyuYamamoto and
YamatoAndo
as code owners
kminoda
changed the title
|
@shmpwk Would you review this if necessary? (Or can I just merge?) I checked that logging_simulator runs as intended. |
shmpwk
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Must be merged with
NOTE!!!: We also need to update the ML model. See https://evaluation.tier4.jp/evaluation/mlpackages/5b56c824-de65-406e-b12f-d7271589cc70/releases/ec5e8e23-e85a-463f-aa36-c8150363a820?project_id=zWhWRzei
Tests performed
Launch pilot-auto.xx1 with logging_simulator and confirmed that it works with odaiba rosbag (both localization & perception).
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.