Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): terminal lane change and abort behavior #1141

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

rej55
Copy link
Collaborator

@rej55 rej55 commented Feb 9, 2024

Description

Cherry-pick

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

zulfaqar-azmi-t4 and others added 4 commits February 9, 2024 17:36
…tion#6088)

* refactor(lane_change): update lc status in updateData

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* update current lane and target lane during requested

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* set is_valid_path as false by default

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* reset flags after finished lane change

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…val (autowarefoundation#6176)

* saved

Signed-off-by: Fumiya Watanabe <[email protected]>

* feat(lane_change): fix drivable area info

Signed-off-by: Fumiya Watanabe <[email protected]>

* feat(lane_change): update filter object

Signed-off-by: Fumiya Watanabe <[email protected]>

* feat(lane_change): fix turn signal

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): fix typo

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): remove updateLaneChangeStatus()

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): remove redundant process

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): calculate distance to goal

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): add empty guard

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit 2c42fdb into beta/v0.20.1 Feb 9, 2024
13 checks passed
@shmpwk shmpwk deleted the feat/wait_approval_at_abort branch February 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants