chore(image_projection_based_fusion): rework parameters (#6169) #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <[email protected]> * docs: update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Shin-kyoto
requested review from
badai-nguyen,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
Shin-kyoto
requested review from
shmpwk
and removed request for
yukkysaito,
YoshiRi,
miursh,
tzhong518,
ktro2828 and
badai-nguyen
|
Also should merge https://github.com/tier4/pilot-auto.xx1/pull/794 at the same time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hotfix: merge rework parameter PR to pilot-auto.xx1 v0.44.1.0
Ref: https://star4.slack.com/archives/CEV8XMJBV/p1709004315021389?thread_ts=1708431764.969459&cid=CEV8XMJBV
https://github.com/tier4/autoware_launch.xx1/pull/791#issue-2155587340
Tests performed
I did not check this PR.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.