feat(behavior_velocity_traffic_light): check if remaining time is available #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomohitoAndo
changed the title
…t is unavailable Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
force-pushed
the
check-if-remaining-time-available
branch
from
495be7d to
2be630b
Compare
TomohitoAndo
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168 and
tkimura4
as code owners
TomohitoAndo
requested review from
0x126 and
saka1-s
and removed request for
takayuki5168,
soblin,
kyoichi-sugahara,
kosuke55,
shmpwk,
satoshi-ota,
tkimura4,
taikitanaka3 and
maxime-clem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
※この変更はV2Iの残り時間情報を使うuniverse versionでのみ有効なため、beta/v0.19.1に変更を加えている
Related link: TIER IV INTERNAL
Handled the case when the remaining time is unavailable.
has_max_rest_timeis false orhas_min_rest_timeis falseNOTE:
This PR should be merged after this PR
I will rebase after following PR has been merged.
-> DONE
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.