forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multi_object_tracker): tracker update for bugfix on unstable motorbike-cyclist-pedetrian tracking result #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error and overflow on IoU calculation (autowarefoundation#6597) * fix: set object minimum size limits Signed-off-by: Taekjin LEE <[email protected]> * fix: object shape conversion, from cylinder to bbox Signed-off-by: Taekjin LEE <[email protected]> * fix: adjust minimum sizes to 0.3 m The minimum size is unified to a small number (0.3 m) to avoid side-effect of tracking. Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
…undation#6587) * fix: define function to adjust object yaw angle for ekf update Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring Signed-off-by: Taekjin LEE <[email protected]> * feat: update tracking offset to object position Signed-off-by: Taekjin LEE <[email protected]> * fix: enlarge yaw noise when the orientation is unknown Signed-off-by: Taekjin LEE <[email protected]> * fix: rearrange obj extension, noise model, observation vector length Signed-off-by: Taekjin LEE <[email protected]> * chore: grouping part of codes Signed-off-by: Taekjin LEE <[email protected]> * fix: separate object pre-process getUpdatingObject Signed-off-by: Taekjin LEE <[email protected]> * fix: bicycle tracker object preprocessing Signed-off-by: Taekjin LEE <[email protected]> * feat: separated motion model class, not tested Signed-off-by: Taekjin LEE <[email protected]> * feat: add motion model Signed-off-by: Taekjin LEE <[email protected]> * feat: replace tracker to motion model class Signed-off-by: Taekjin LEE <[email protected]> * feat: normal vehicle tracker replace to motion model Signed-off-by: Taekjin LEE <[email protected]> * feat: big vehicle tracker is replaced by motion model Signed-off-by: Taekjin LEE <[email protected]> * feat: bicycle tracker replace by motion model Signed-off-by: Taekjin LEE <[email protected]> * chore: remove non-used members Signed-off-by: Taekjin LEE <[email protected]> * feat: add CTRV motion model and implement it to pedestrian tracker Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring parameters Signed-off-by: Taekjin LEE <[email protected]> * fix: object initialization Signed-off-by: Taekjin LEE <[email protected]> * chore: grouping param setting Signed-off-by: Taekjin LEE <[email protected]> * feat: create cv motion model, not tested Signed-off-by: Taekjin LEE <[email protected]> * feat: implementing unknown tracker, process is dying Signed-off-by: Taekjin LEE <[email protected]> * fix: align number precisions to double Signed-off-by: Taekjin LEE <[email protected]> * fix: resolve overflow issue by including proper header files Signed-off-by: Taekjin LEE <[email protected]> * fix: missing twist cov Signed-off-by: Taekjin LEE <[email protected]> * fix: limit too large dt on unknown tracker, set size gain to 0.1 Signed-off-by: Taekjin LEE <[email protected]> * fix: set parameter before init Signed-off-by: Taekjin LEE <[email protected]> * chore: fix init to initialize chore: fix init to initialize Signed-off-by: Taekjin LEE <[email protected]> * feat: motion model base class Signed-off-by: Taekjin LEE <[email protected]> * feat: common methods to the base class Signed-off-by: Taekjin LEE <[email protected]> * fix: access to state vector Signed-off-by: Taekjin LEE <[email protected]> * fix: remove not-used tracker's last_update_time_ member Signed-off-by: Taekjin LEE <[email protected]> * Revert "fix: remove not-used tracker's last_update_time_ member" This reverts commit bd8aabb. Signed-off-by: Taekjin LEE <[email protected]> * fix: header cleanup Signed-off-by: Taekjin LEE <[email protected]> * fix: relocate motion models Signed-off-by: Taekjin LEE <[email protected]> * fix: timestamp const Signed-off-by: Taekjin LEE <[email protected]> * fix: exception when object couldn't be predicted Signed-off-by: Taekjin LEE <[email protected]> * fix: remove last_update_time_ member Signed-off-by: Taekjin LEE <[email protected]> * fix: set minimum size, to avoid iou error/overflow Signed-off-by: Taekjin LEE <[email protected]> * fix: rollback tracking size and offset algorithm Signed-off-by: Taekjin LEE <[email protected]> * fix: set minimum pedestrian size Signed-off-by: Taekjin LEE <[email protected]> * fix: adjust minimum sizes to 0.3m Signed-off-by: Taekjin LEE <[email protected]> * chore: cleanup unused members Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
* fix: add cspell ignore for CTRV * Update perception/multi_object_tracker/CMakeLists.txt * Update perception/multi_object_tracker/CMakeLists.txt * Update perception/multi_object_tracker/include/multi_object_tracker/tracker/model/pedestrian_tracker.hpp * Update perception/multi_object_tracker/include/multi_object_tracker/tracker/motion_model/ctrv_motion_model.hpp * Update perception/multi_object_tracker/src/tracker/motion_model/bicycle_motion_model.cpp
…ntended (autowarefoundation#6611) * bugfix: mot multi-step prediction is not work as intended. back to one-step prediction. Signed-off-by: Taekjin LEE <[email protected]> * fix: remove comment-out codes Signed-off-by: Taekjin LEE <[email protected]> * fix: prediction to use variable kalman filter a bug was found on `predictStateStep` methods * intention: predict the future state of the variable kalman filter `ekf` * bug: using the member kalman filter `ekf_` * fix: get the state vector from the variable kalman filter `ekf` Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
…ocess (autowarefoundation#6607) * feat: object class filter Signed-off-by: Taekjin LEE <[email protected]> * fix: set a member private Signed-off-by: Taekjin LEE <[email protected]> * fix: last filtered label is not useful, remove Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: multiply gain for new class Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: algorithm explanation Signed-off-by: Taekjin LEE <[email protected]> * fix: revise the filtering process flow Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
f4f6971
to
52713bb
Compare
Thank you I will check ant merge to beta/v0.20.1.5 after creating the branch. |
shmpwk
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cherry-picks are for latest tracker updates to fix unstable motorbike-cyclist-pedetrian tracking result, described in the issue ticket.
Related links
Issue ticket https://tier4.atlassian.net/browse/RT1-5645
Merged Original PRs
autowarefoundation#6597
autowarefoundation#6587
autowarefoundation#6606
autowarefoundation#6611
autowarefoundation#6607
Tests performed
Tested on a local recompute.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.