Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emergency_goal_manager, mrm_pull_over_manager): add mrm pull over #1231

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

mkuri
Copy link

@mkuri mkuri commented Apr 8, 2024

Description

Add MRM pull over behavior.

Related links

https://tier4.atlassian.net/browse/RT0-30647

Tests performed

2024-04-09_pull_over3-720p.mp4

Map: Shiojiri_Lv4 1211-20240404090559015686
Command:
ros2 service call /system/mrm/pull_over_manager/operate tier4_system_msgs/srv/OperateMrm "{operate: true}"

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mkuri mkuri requested a review from TomohitoAndo April 9, 2024 07:58
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simplescreenrecorder-2024-04-10_14.19.41.mp4

@mkuri mkuri merged commit 6fc1f54 into beta/v0.19.1 Apr 10, 2024
18 of 20 checks passed
@mkuri mkuri deleted the feature/add-mrm-pull-over-for-v0.19.1 branch April 10, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants