forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): cherr pick avoidance hotfix PRs #1232
Merged
satoshi-ota
merged 48 commits into
beta/v0.19.1
from
hotfix/v0.19.1/cherry-pick-avoidance-pr
Apr 10, 2024
Merged
fix(avoidance): cherr pick avoidance hotfix PRs #1232
satoshi-ota
merged 48 commits into
beta/v0.19.1
from
hotfix/v0.19.1/cherry-pick-avoidance-pr
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refoundation#5855) * fix(avoidance): use centerline of current lanelets in object filtering logic Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix test Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
* feat(avoidance): add new filter for objects in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix object filtering Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): avoid simple merging object Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
* refactor(avoidance): remove unused header Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * remove libboost-dev dependencies Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * removed unused variable. add slight clang-tidy suggestion Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
…of safety check (autowarefoundation#5828) fix(avoidance): use same root adjacent lane Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
…ation#5949) Signed-off-by: satoshi-ota <[email protected]>
…me (autowarefoundation#5863) * fix(planning_test_utils): rename header directory to match project name Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix include Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix includes in downstream packages Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix includes Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix includes Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix includes Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
) * refactor(avoidance): clean up Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): suppress unnecessary turn signal Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): move utils Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…arefoundation#6017) fix(avoidance): output return shift path properly Signed-off-by: satoshi-ota <[email protected]>
* pref(avoidance): don't use boost union_ Signed-off-by: satoshi-ota <[email protected]> * perf(avoidance): reduce frequency to call calcSignedArcLength Signed-off-by: satoshi-ota <[email protected]> * perf(turn_signal): reduce frequency to call calcSignedArcLength Signed-off-by: satoshi-ota <[email protected]> * perf(static_drivable_area_expansion): don't use calcDistance2d Signed-off-by: satoshi-ota <[email protected]> * fix(static_drivable_area_expansion): rename and fix return value consistency Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…t endless loop (autowarefoundation#6084) * perf(avoidance): reduce heavy process Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): filter objects by precise lon distance Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): remove unused function Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): improve detection area Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): return shift line Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…efoundation#6097) * fix(avoidance): fix invalid vector access Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix detection area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…tion (autowarefoundation#6285) Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: Kotaro Yoshimoto <[email protected]>
…efoundation#6320) Signed-off-by: satoshi-ota <[email protected]>
…warefoundation#6330) fix(avoidance): fix duplicated marker id Signed-off-by: satoshi-ota <[email protected]>
…neously (autowarefoundation#5979) * feat(avoidance/goal_planner): execute avoidance and pull over simultaneously Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> * use utils Signed-off-by: kosuke55 <[email protected]> * fix overlapped Signed-off-by: kosuke55 <[email protected]> * reafactor(behavior_path_planner): move isAllowedGoalModification to common Signed-off-by: kosuke55 <[email protected]> * fix readme Signed-off-by: kosuke55 <[email protected]> * add goal modification condtion to avoidance Signed-off-by: kosuke55 <[email protected]> * clean up * revert param Signed-off-by: kosuke55 <[email protected]> * fix param Signed-off-by: kosuke55 <[email protected]> * move dead line process Signed-off-by: kosuke55 <[email protected]> * fix condition Signed-off-by: kosuke55 <[email protected]> * fix crop Signed-off-by: kosuke55 <[email protected]> * fix crop * fix typos Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
…ing state transition (autowarefoundation#6172) Update drivable area info and enable idle to running state transition Signed-off-by: kyoichi-sugahara <[email protected]>
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…rocessing logic (autowarefoundation#5928) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6014) Signed-off-by: satoshi-ota <[email protected]>
… module (autowarefoundation#6001) * fix(static_drivable_area_expansion): check right/left bound id Signed-off-by: satoshi-ota <[email protected]> * feat(static_drivable_area): use freespace area Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): use freespace Signed-off-by: satoshi-ota <[email protected]> * fix(AbLC): fix flag Signed-off-by: satoshi-ota <[email protected]> * fix(planner_manager): fix flag Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): remove unused arg Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): use lambda Signed-off-by: satoshi-ota <[email protected]> * fix(static_drivable_area_expansion): fix invalid access Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): improve readability Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): add param Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…ary during unsafe condition (autowarefoundation#6355) * fix(avoidance): don't slow down if avoidance is NOT definitely necessary during unsafe condition Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): don't insert stop point when the path is invalid Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): update parameter namespace Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…warefoundation#6601) * feat(avoidance): output overhang lanelet Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): avoid merging vehicle if it's NOT on ego lane. Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): add flag to identify ambiguous vehicle Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): add helper function Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): rename param Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update comment Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…dation#6631) * feat(avoidance): wait and see the ambiguous stopped vehicle Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): wait and see objects around ego straight lane Signed-off-by: satoshi-ota <[email protected]> * tmp Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): filtering logic for vehicle type objects Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): wait with unsafe avoidance path Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): use getRightLanelet Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): parameterize Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
requested review from
kosuke55,
takayuki5168,
rej55,
shmpwk,
taikitanaka3,
TakaHoribe,
tkimura4,
kyoichi-sugahara,
maxime-clem,
mkuri,
0x126,
TomohitoAndo,
soblin and
zulfaqar-azmi-t4
as code owners
April 8, 2024 01:22
…refoundation#6698) Signed-off-by: satoshi-ota <[email protected]>
…dation#6759) * fix(avoidance): add update param to use rqt reconfigure Signed-off-by: satoshi-ota <[email protected]> * Update planning/behavior_path_avoidance_module/src/manager.cpp Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_avoidance_module/src/manager.cpp Co-authored-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]>
…le (autowarefoundation#6768) fix(avoidance): adjacent lane check for ambiguous stopped vehicle Signed-off-by: satoshi-ota <[email protected]>
mkuri
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update avoidance module.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.