Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hazard_status_converter): check current operation mode (cherrypick autowarefoundation#6733) #1235

Merged

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Apr 9, 2024

  • fix: hazard status converter

Signed-off-by: Takagi, Isamu [email protected]

  • fix: topic name and modes

Signed-off-by: Takagi, Isamu [email protected]

  • fix check target mode

Signed-off-by: Takagi, Isamu [email protected]

  • fix message type

Signed-off-by: Takagi, Isamu [email protected]

  • Revert "fix check target mode"

This reverts commit 8b190b7.


Signed-off-by: Takagi, Isamu [email protected]
(cherry picked from commit 41aab51)

Description

Related links

autowarefoundation#6733

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…oundation#6733)

* fix: hazard status converter

Signed-off-by: Takagi, Isamu <[email protected]>

* fix: topic name and modes

Signed-off-by: Takagi, Isamu <[email protected]>

* fix check target mode

Signed-off-by: Takagi, Isamu <[email protected]>

* fix message type

Signed-off-by: Takagi, Isamu <[email protected]>

* Revert "fix check target mode"

This reverts commit 8b190b7.

---------

Signed-off-by: Takagi, Isamu <[email protected]>
(cherry picked from commit 41aab51)
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo HansRobo merged commit bf03972 into beta/v0.19.1 Apr 9, 2024
14 of 15 checks passed
@HansRobo HansRobo deleted the beta/v0.19.1+41aab5122d416fd9c83ea49885eb5bf07673daf2 branch April 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants