chore(ground_segmentation): cherry pick pr6209+5861+6753+5980 #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
component:perception
component:sensing
labels
badai-nguyen
requested review from
amc-nu,
miursh and
yukkysaito
as code owners
0x126
force-pushed
the
cherry-pick/pr6209+5861+6753
branch
from
f9d4718 to
e2d148b
Compare
badai-nguyen
changed the title
* chore: remove default params Signed-off-by: badai-nguyen <[email protected]> * fix: scan ground gtest Signed-off-by: badai-nguyen <[email protected]> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
* perf(scan_ground_filter): performance tuning Signed-off-by: taisa1 <[email protected]> * perf(scan_ground_filter): improved performance Signed-off-by: taisa1 <[email protected]> * chore: refactoring Signed-off-by: taisa1 <[email protected]> * chore: refactoring Signed-off-by: taisa1 <[email protected]> * refactor: reflect review Signed-off-by: taisa1 <[email protected]> * style(pre-commit): autofix * fix: remove unnecessary comment Signed-off-by: taisa1 <[email protected]> * test: change unit test to use faster_filter Signed-off-by: taisa1 <[email protected]> * test: fixed compile error Signed-off-by: taisa1 <[email protected]> * fix: add lacking parameter callback Signed-off-by: taisa1 <[email protected]> * fix: uninitialized valuabe Signed-off-by: atsushi421 <[email protected]> --------- Signed-off-by: taisa1 <[email protected]> Signed-off-by: atsushi421 <[email protected]> Co-authored-by: taisa1 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: atsushi yano <[email protected]> Co-authored-by: atsushi421 <[email protected]>
* chore(ground_segmentation): add tuning param Signed-off-by: badai-nguyen <[email protected]> * fix: and param into yaml file Signed-off-by: badai-nguyen <[email protected]> * chore: typo Signed-off-by: badai-nguyen <[email protected]> * chore: typo Signed-off-by: badai-nguyen <[email protected]> * chore: refactor Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
…efoundation#5980) * improve perfomance Signed-off-by: Taiga Takano <[email protected]> * style(pre-commit): autofix Signed-off-by: Taiga Takano <[email protected]> * fixed the bug and corrected the spelling mistake. Signed-off-by: Taiga Takano <[email protected]> * style(pre-commit): autofix Signed-off-by: Taiga Takano <[email protected]> * fix bug Signed-off-by: Taiga Takano <[email protected]> * style(pre-commit): autofix Signed-off-by: Taiga Takano <[email protected]> * change filter Signed-off-by: Taiga Takano <[email protected]> --------- Signed-off-by: Taiga Takano <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <[email protected]>
0x126
force-pushed
the
cherry-pick/pr6209+5861+6753
branch
from
8107cb1 to
1d957c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to add param for tuning and improve the computational cost and time.
Releated PR:
Releated Link
TIER IV INTERNAL LINK: ticket 1 and ticket 2
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.