fix(lane_change): cherry pick small fixes #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arefoundation#6726) * feat(lane_change): check prepare phase in turn direction lanes Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Doxygen comment Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Add config Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix comments by the reviewer Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…arefoundation#6760) * feat(lane_change): use external velocity limit in safety check Signed-off-by: Muhammad Zulfaqar <[email protected]> * style(pre-commit): autofix * Minor refactoring Signed-off-by: Muhammad Zulfaqar <[email protected]> * Fix spell check and remove headers Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Add warning Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zulfaqar-azmi-t4
requested review from
danielsanchezaran,
rej55,
kosuke55,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4,
kyoichi-sugahara and
TomohitoAndo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/tier4/autoware_launch.xx1/pull/832
Cherry pick the following commits.
feat(lane_change): check prepare phase in turn direction lanes #6726
feat(lane_change): use external velocity limit in safety check #6760
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.