Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compare_map_segmentation): vertical check adjust for low height object detection #1243

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

badai-nguyen
Copy link

Description

  • This is a temporal change for compare map filter to retain the obstacle pointcloud of low height objects.

Releated Link

TIER IV INTERNAL LINK: ticket 1 and ticket 2

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen badai-nguyen requested review from YoshiRi and 0x126 April 10, 2024 09:05
@badai-nguyen badai-nguyen marked this pull request as ready for review April 10, 2024 09:06
@0x126 0x126 force-pushed the fix/compare_map_segmentation_vertical_check branch from a4b65a4 to 34b4fee Compare April 16, 2024 00:22
@badai-nguyen
Copy link
Author

@YoshiRi 先日直接にワイドボードで話したCompare_map_filterの件はこのPRを反映しますのでApproveしていただけますか?

Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126 0x126 merged commit 99a140b into beta/v0.19.1 Apr 19, 2024
12 of 13 checks passed
@0x126 0x126 deleted the fix/compare_map_segmentation_vertical_check branch April 19, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants