Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fault injection): change for diagnostic graph aggregator (#6750) #1247

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Apr 11, 2024

Description

Cherry pick this PR to update the fault injection node to support the diagnostic graph aggregator.

Related link (TIER IV INTERNAL)
https://star4.slack.com/archives/CRUE57C30/p1711711110406479?thread_ts=1711339682.083009&cid=CRUE57C30

Tests performed

See autowarefoundation#6750 (comment)

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…refoundation#6750)

* feat: change to adapt diagnostic graph aggregator

Signed-off-by: Keisuke Shima <[email protected]>

* Change the configuration to adapt to both system_error_monitor and diagnostic_graph_aggregator

Signed-off-by: Keisuke Shima <[email protected]>

* style(pre-commit): autofix

* pre-commit fix

Signed-off-by: Keisuke Shima <[email protected]>

* style(pre-commit): autofix

* spell check fix

Signed-off-by: Keisuke Shima <[email protected]>

* clang-tidy fix

Signed-off-by: Keisuke Shima <[email protected]>

* style(pre-commit): autofix

* pre-commit fix

Signed-off-by: Keisuke Shima <[email protected]>

* style(pre-commit): autofix

* fix datatype

Signed-off-by: Keisuke Shima <[email protected]>

* cleanup code

Signed-off-by: Keisuke Shima <[email protected]>

---------

Signed-off-by: Keisuke Shima <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomohito ANDO <[email protected]>
Copy link

@dai0912th dai0912th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo enabled auto-merge (squash) April 11, 2024 01:16
@TomohitoAndo TomohitoAndo merged commit 748e12b into beta/v0.19.1 Apr 11, 2024
18 of 20 checks passed
@TomohitoAndo TomohitoAndo deleted the cherry-pick-6750 branch April 11, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants