fix(behavior_velocity_traffic_light): do not use the timed out remain… #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing time information Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
requested review from
satoshi-ota,
shmpwk and
tkimura4
as code owners
TomohitoAndo
requested review from
0x126 and
saka1-s
and removed request for
shmpwk,
satoshi-ota and
tkimura4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: TIER IV INTERNAL
Important
This fix has been applied only to the beta/v0.19.1 branch, as the use of remaining time data is only implemented in this branch.
I resolved the issue where outdated timestamp data was retained in the remaining time information.
I updated the code to skip using the remaining time if it is outdated.
Tests performed
Scenario Simulator
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.