Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aeb): update aeb module and add control evaluator #1304

Merged
merged 5 commits into from
May 17, 2024

Conversation

danielsanchezaran
Copy link

@danielsanchezaran danielsanchezaran commented May 17, 2024

Description

Update AEB module and add control evaluator for AEB monitoring:

cherry-picked PRs:
autowarefoundation#6966 (AEB update)
autowarefoundation#6875 (AEB update)
autowarefoundation#6912 (AEB update)
c66d576 (Param update with rqt_reconfigure for AEB)
autowarefoundation#6959 (Add control evaluator node)

Requires launch changes: https://github.com/tier4/autoware_launch.xx1/pull/853

Tests performed

PSim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…utowarefoundation#6875)

* enable aeb, fix topic problem

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate unused var

Signed-off-by: Daniel Sanchez <[email protected]>

* enable aeb, fix topic problem

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate unused var

Signed-off-by: Daniel Sanchez <[email protected]>

* add clustering method to eliminate small objects/noise

Signed-off-by: Daniel Sanchez <[email protected]>

* remove comments

Signed-off-by: Daniel Sanchez <[email protected]>

* Crop points outside of EGO predicted path

Signed-off-by: Daniel Sanchez <[email protected]>

* remove offset

Signed-off-by: Daniel Sanchez <[email protected]>

* Update library use

Signed-off-by: Daniel Sanchez <[email protected]>

* add check for empty cloud

Signed-off-by: Daniel Sanchez <[email protected]>

* add extra width for pointcloud cropping

Signed-off-by: Daniel Sanchez <[email protected]>

* Use single PC ptr

Signed-off-by: Daniel Sanchez <[email protected]>

* remove problematic option

Signed-off-by: Daniel Sanchez <[email protected]>

* Revert "Use single PC ptr"

This reverts commit b5091fc.

Signed-off-by: Daniel Sanchez <[email protected]>

* refactoring

Signed-off-by: Daniel Sanchez <[email protected]>

* Add back timestamp

Signed-off-by: Daniel Sanchez <[email protected]>

* consider all points in clusters

Signed-off-by: Daniel Sanchez <[email protected]>

* USe object hull to detect collisions

Signed-off-by: Daniel Sanchez <[email protected]>

* Use only closest object point

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unused functions

Signed-off-by: Daniel Sanchez <[email protected]>

* remove debug timer out of code

Signed-off-by: Daniel Sanchez <[email protected]>

* make it so the clustering uses parameters

Signed-off-by: Daniel Sanchez <[email protected]>

* solve type problem

Signed-off-by: Daniel Sanchez <[email protected]>

* update comment

Signed-off-by: Daniel Sanchez <[email protected]>

* update README

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate member var in favor of local pointcloud ptr

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unused chrono dependency

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
…for AEB (autowarefoundation#6912)

* enable aeb, fix topic problem

Signed-off-by: Daniel Sanchez <[email protected]>

* add clustering method to eliminate small objects/noise

Signed-off-by: Daniel Sanchez <[email protected]>

* remove comments

Signed-off-by: Daniel Sanchez <[email protected]>

* Crop points outside of EGO predicted path

Signed-off-by: Daniel Sanchez <[email protected]>

* remove offset

Signed-off-by: Daniel Sanchez <[email protected]>

* Update library use

Signed-off-by: Daniel Sanchez <[email protected]>

* add check for empty cloud

Signed-off-by: Daniel Sanchez <[email protected]>

* add extra width for pointcloud cropping

Signed-off-by: Daniel Sanchez <[email protected]>

* Use single PC ptr

Signed-off-by: Daniel Sanchez <[email protected]>

* Revert "Use single PC ptr"

This reverts commit b5091fc.

Signed-off-by: Daniel Sanchez <[email protected]>

* Add back timestamp

Signed-off-by: Daniel Sanchez <[email protected]>

* USe object hull to detect collisions

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unused functions

Signed-off-by: Daniel Sanchez <[email protected]>

* remove debug timer out of code

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate member var in favor of local pointcloud ptr

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unused chrono dependency

Signed-off-by: Daniel Sanchez <[email protected]>

* Add object history to etimate object speed with pointcloud

Signed-off-by: Daniel Sanchez <[email protected]>

* Add median velocity calc

Signed-off-by: Daniel Sanchez <[email protected]>

* add velocity thresholds

Signed-off-by: Daniel Sanchez <[email protected]>

* refactoring

Signed-off-by: Daniel Sanchez <[email protected]>

* cleaning

Signed-off-by: Daniel Sanchez <[email protected]>

* refactor

Signed-off-by: Daniel Sanchez <[email protected]>

* change voxwl

Signed-off-by: Daniel Sanchez <[email protected]>

* readme

Signed-off-by: Daniel Sanchez <[email protected]>

* remove mutex since they are not necessary

Signed-off-by: Daniel Sanchez <[email protected]>

* add markers for closest object velocity

Signed-off-by: Daniel Sanchez <[email protected]>

* added units to marker

Signed-off-by: Daniel Sanchez <[email protected]>

* delete duplicated param

Signed-off-by: Daniel Sanchez <[email protected]>

* delete duplicated param

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
…ation#6959)

* add control evaluator module

Signed-off-by: Daniel Sanchez <[email protected]>

* make the evaluator depend on messages from AEB

Signed-off-by: Daniel Sanchez <[email protected]>

* update output msg

Signed-off-by: Daniel Sanchez <[email protected]>

* delete extra new line

Signed-off-by: Daniel Sanchez <[email protected]>

* update/fix details

Signed-off-by: Daniel Sanchez <[email protected]>

* add a package mantainer

Signed-off-by: Daniel Sanchez <[email protected]>

* Add a timer to maintain a constant rate of msg publishing

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit 84f58a5 into beta/v0.26.1 May 17, 2024
19 checks passed
@shmpwk shmpwk deleted the update-aeb-module branch May 17, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants