feat(pointcloud preprocessor): add hysteresis to diag #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x126
requested review from
amc-nu,
miursh,
yukkysaito and
YoshiRi
as code owners
0x126
requested review from
TomohitoAndo
and removed request for
amc-nu,
yukkysaito,
YoshiRi and
miursh
0x126
changed the title
4 tasks
kotaro-hihara
pushed a commit
that referenced
this pull request
Aug 29, 2024
* remove diagnostics_updater * add counter * change node name * rename * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kotaro-hihara <[email protected]>
kotaro-hihara
pushed a commit
that referenced
this pull request
Nov 21, 2024
* remove diagnostics_updater * add counter * change node name * rename * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kotaro-hihara <[email protected]>
kotaro-hihara
added a commit
that referenced
this pull request
Nov 21, 2024
* feat(pointcloud preprocessor): add hysteresis to diag (#1309) * remove diagnostics_updater * add counter * change node name * rename * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kotaro-hihara <[email protected]> * fix(pointcloud_preprocessor): typo consecutive_concatenate_failures (#1310) --------- Signed-off-by: kotaro-hihara <[email protected]> Co-authored-by: Shinnosuke Hirakawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shumpei Wakabayashi <[email protected]>
TetsuKawa
pushed a commit
that referenced
this pull request
Dec 1, 2024
* feat(pointcloud preprocessor): add hysteresis to diag (#1309) * remove diagnostics_updater * add counter * change node name * rename * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kotaro-hihara <[email protected]> * fix(pointcloud_preprocessor): typo consecutive_concatenate_failures (#1310) --------- Signed-off-by: kotaro-hihara <[email protected]> Co-authored-by: Shinnosuke Hirakawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shumpei Wakabayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stopped using diagnostics_updater to control /diagnostics publish timing
Changed to publish diagnostics in WARN only when concat fails for more than 2 consecutive frames
changed the node name of segmentation to distinguish between sensing concat and segmentation concat
Related links
Tests performed
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.