Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: daynamic reconfigurable is_mrm_recoverable parameter #1333

Conversation

saka1-s
Copy link

@saka1-s saka1-s commented Jun 12, 2024

Description

is_mrm_recoverableをTrueにした場合、autowareを再起動しないとMRMから復帰できない。
ソフトウェアの仕様としては正しいが、実験する上で可用性が低いため、
is_mrm_recoverableパラメータを動的に変更することを許可する。

MRMからの復帰
ros2 param set /system/mrm_handler is_mrm_recoverable True

mrm_reconfigure.mp4

Tests performed

Psimで実験した。
走行開始→Emergency発生→MRMによる緊急停止→Emergency解除(MRM復帰せず)→is_mrm_recoverableをTrueに変更→再発進

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@saka1-s saka1-s requested a review from mkuri June 12, 2024 02:26
@saka1-s saka1-s force-pushed the feat/dynamic_reconfigure_mrm_holding_v0.19.1 branch from 64226bf to a8a369a Compare June 12, 2024 02:30
@saka1-s saka1-s force-pushed the feat/dynamic_reconfigure_mrm_holding_v0.19.1 branch from a8a369a to 54972ac Compare June 12, 2024 02:35
@saka1-s saka1-s marked this pull request as ready for review June 12, 2024 02:41
Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@saka1-s saka1-s merged commit 8aa0062 into tier4:beta/v0.19.1 Jun 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants