Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): add duplicate nodes to ignore (#7959) #1410

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Jul 11, 2024

Description

autowarefoundation#7959
( autowarefoundation/autoware_launch#1070 )

Hotfix to beta/v0.29.0

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…efoundation#7959)

* feat: add duplicate nodes to ignore

Signed-off-by: Dmitrii Koldaev <[email protected]>

* remove talker

Signed-off-by: Dmitrii Koldaev <[email protected]>

* newline

Signed-off-by: Dmitrii Koldaev <[email protected]>

* commments

Signed-off-by: Dmitrii Koldaev <[email protected]>

* pre-commit and sign

Signed-off-by: Dmitrii Koldaev <[email protected]>

* rviz->rviz2

Signed-off-by: Dmitrii Koldaev <[email protected]>

---------

Signed-off-by: Dmitrii Koldaev <[email protected]>
Co-authored-by: Dmitrii Koldaev <[email protected]>
@tkimura4 tkimura4 requested review from soblin and shmpwk as code owners July 11, 2024 05:43
@tkimura4 tkimura4 removed the request for review from soblin July 11, 2024 05:43
Copy link

@shmpwk shmpwk merged commit 898eb5a into beta/v0.29.0 Jul 11, 2024
25 of 26 checks passed
@shmpwk shmpwk deleted the fix/add_duplicate_nodes_to_ignore-v0.29.0 branch July 11, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants