Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement service for clear MRM behavior #1511

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

saka1-s
Copy link

@saka1-s saka1-s commented Sep 4, 2024

Description

We implement a service to reset MRM behavior.

Specification of interface

service name: /system/clear_mrm
service type: std_srvs/Trigger

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

sonarqubecloud bot commented Sep 4, 2024

@saka1-s saka1-s marked this pull request as ready for review September 5, 2024 08:01
@saka1-s saka1-s requested a review from 0x126 September 5, 2024 08:15
Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saka1-s saka1-s merged commit 23b5356 into tier4:beta/v0.19.1 Sep 6, 2024
10 of 11 checks passed
TomohitoAndo pushed a commit that referenced this pull request Nov 21, 2024
* implement service for clear MRM behavior

* clang format

Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo pushed a commit that referenced this pull request Nov 22, 2024
* implement service for clear MRM behavior

* clang format

Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo added a commit that referenced this pull request Nov 23, 2024
* feat(mrm_handler): mrm recoverable option (#1316)

* implement is_mrm_recoverable option of mrm_handler

* add pull over after stopped option

* update json schema of mrm_handler

Signed-off-by: Tomohito Ando <[email protected]>

* feat: implement service for clear MRM behavior (#1511)

* implement service for clear MRM behavior

* clang format

Signed-off-by: Tomohito Ando <[email protected]>

* feat: implement MRM automatic recovery feature

Signed-off-by: Tomohito Ando <[email protected]>

* fix typo

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
TetsuKawa pushed a commit that referenced this pull request Dec 1, 2024
* feat(mrm_handler): mrm recoverable option (#1316)

* implement is_mrm_recoverable option of mrm_handler

* add pull over after stopped option

* update json schema of mrm_handler

Signed-off-by: Tomohito Ando <[email protected]>

* feat: implement service for clear MRM behavior (#1511)

* implement service for clear MRM behavior

* clang format

Signed-off-by: Tomohito Ando <[email protected]>

* feat: implement MRM automatic recovery feature

Signed-off-by: Tomohito Ando <[email protected]>

* fix typo

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants