fix(lane_change): reduce approval chattering #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(lane_change): cancel hysteresis Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Update documentation Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix the explanation of the hysteresis count Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
|
zulfaqar-azmi-t4
changed the title
takayuki5168
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where lane change module's approvals chatter when there's many parked object present.
These commits are already in the main branch, however due to the significant amount of conflicts, cherry-pick is not possible.
Before PR
Chattering is present before the final approval.
cap-.2024-10-01-14-32-17.mp4
After PR
The chattering is removed.
cap-.2024-10-01-14-24-59.mp4
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.