fix(autonomous_emergency_braking): add sanity checks (#8998) #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#8998) add sanity chackes Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
changed the title
|
|
Test results are images only, test cases are unknown. |
I updated the description. |
sfukuta
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add sanity checks to prevent crashes (cherry-pick #8998)
Description
Related links
Related issue ticket: https://tier4.atlassian.net/browse/RT0-33710?focusedCommentId=188714
Parent Issue:
How was this PR tested?
The changes only involve checking for vector emptiness so there is no change to the AEB behavior. Regardless, compilation was performed and Psim was used to test if the module compiles properly and if there are no problems.
Psim simulation to see if the AEB module runs without problems and compiles properly: As it can be seen in the image below, the module executes without problems. Objects were also placed on the simulated vehicle way to see if the module works properly. No problems found.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.