Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_run_out_module): exclude obstacle crossing ego… #1574

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

danielsanchezaran
Copy link

@danielsanchezaran danielsanchezaran commented Oct 4, 2024

Description

Add ego cut line to prevent rear pedestrians/bicycles from activating AEB. Cherry-pick of autowarefoundation#6680

Requires launch changes: https://github.com/tier4/autoware_launch.x2/pull/812

Related links

Solves this Ticket:
https://tier4.atlassian.net/browse/RT0-33694 (evidence in ticket)

Parent Issue:

  • Link

How was this PR tested?

Psim and evaluator: https://evaluation.ci.tier4.jp/evaluation/reports/b065a943-eab7-544a-9782-bbd6e49c8e98?project_id=x2_dev

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

… back line (autowarefoundation#6680)

* add method to ignore target obstacles that cross ego cut lane

Signed-off-by: Daniel Sanchez <[email protected]>

* WIP add debug support

Signed-off-by: Daniel Sanchez <[email protected]>

* add params and finish debug marker

Signed-off-by: Daniel Sanchez <[email protected]>

* change lane to line

Signed-off-by: Daniel Sanchez <[email protected]>

* use autoware utils to get the cut line

Signed-off-by: Daniel Sanchez <[email protected]>

* simplify code wit calcOffsetPose

Signed-off-by: Daniel Sanchez <[email protected]>

* Update readme and eliminate unused code

Signed-off-by: Daniel Sanchez <[email protected]>

* update readme

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate unused function

Signed-off-by: Daniel Sanchez <[email protected]>

* readme

Signed-off-by: Daniel Sanchez <[email protected]>

* comments and readme

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate unused include

Signed-off-by: Daniel Sanchez <[email protected]>

* typo

Signed-off-by: Daniel Sanchez <[email protected]>

* rename param for consistency

Signed-off-by: Daniel Sanchez <[email protected]>

* change lane to line for consistency

Signed-off-by: Daniel Sanchez <[email protected]>

* rename for clarity, add brief

Signed-off-by: Daniel Sanchez <[email protected]>

* fix indentation

Signed-off-by: Daniel Sanchez <[email protected]>

* update description

Signed-off-by: Daniel Sanchez <[email protected]>

* lane ->line

Signed-off-by: Daniel Sanchez <[email protected]>

* lane -> line

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
@takayuki5168
Copy link

影響範囲が大きいのでドラフトに

Copy link

sonarcloud bot commented Oct 4, 2024

@takayuki5168 takayuki5168 marked this pull request as ready for review October 9, 2024 07:40
@takayuki5168 takayuki5168 merged commit b25fd6b into beta/v0.19.1-pc-develop Oct 9, 2024
15 of 18 checks passed
@takayuki5168 takayuki5168 deleted the tune/x2-3.0.0-run-out branch October 9, 2024 07:40
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Oct 29, 2024
tier4#1574)

feat(behavior_velocity_run_out_module): exclude obstacle crossing ego back line (autowarefoundation#6680)

* add method to ignore target obstacles that cross ego cut lane



* WIP add debug support



* add params and finish debug marker



* change lane to line



* use autoware utils to get the cut line



* simplify code wit calcOffsetPose



* Update readme and eliminate unused code



* update readme



* eliminate unused function



* readme



* comments and readme



* eliminate unused include



* typo



* rename param for consistency



* change lane to line for consistency



* rename for clarity, add brief



* fix indentation



* update description



* lane ->line



* lane -> line



---------

Signed-off-by: Daniel Sanchez <[email protected]>
saka1-s added a commit that referenced this pull request Oct 31, 2024
* feat(lane_change): cancel hysteresis (autowarefoundation#6288)

* feat(lane_change): cancel hysteresis

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Update documentation

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix the explanation of the hysteresis count

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Add parked parked RSS

Signed-off-by: Zulfaqar Azmi <[email protected]>

* support new perception_reproducer

Signed-off-by: temkei.kem <[email protected]>

* move files

Signed-off-by: temkei.kem <[email protected]>

* remove old files.

Signed-off-by: temkei.kem <[email protected]>

* fix pre-commit err

Signed-off-by: temkei.kem <[email protected]>

* style(pre-commit): autofix

* feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity (#1571)

Refactor turn signal decider logic and add support for detecting turn signals in turn lanes

Signed-off-by: Kyoichi Sugahara <[email protected]>

* fix a small bug about perception reproducer

* style(pre-commit): autofix

* feat(out_of_lane): ignore lanelets beyond the last path point (#1554)

* feat(out_of_lane): ignore lanelets beyond the last path point

Signed-off-by: Maxime CLEMENT <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(behavior_velocity_run_out_module): exclude obstacle crossing ego… (#1574)

feat(behavior_velocity_run_out_module): exclude obstacle crossing ego back line (autowarefoundation#6680)

* add method to ignore target obstacles that cross ego cut lane



* WIP add debug support



* add params and finish debug marker



* change lane to line



* use autoware utils to get the cut line



* simplify code wit calcOffsetPose



* Update readme and eliminate unused code



* update readme



* eliminate unused function



* readme



* comments and readme



* eliminate unused include



* typo



* rename param for consistency



* change lane to line for consistency



* rename for clarity, add brief



* fix indentation



* update description



* lane ->line



* lane -> line



---------

Signed-off-by: Daniel Sanchez <[email protected]>

* fix(lane_change): change stopping logic (RT0-33761) (#1581)

* RT0-33761 fix lane change stopping logic

Signed-off-by: Zulfaqar Azmi <[email protected]>

* copied from awf main tested implementation

Signed-off-by: Zulfaqar Azmi <[email protected]>

* doxygen comment

Signed-off-by: Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_lane_change_module/src/utils/utils.cpp

Co-authored-by: mkquda <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
Co-authored-by: mkquda <[email protected]>

* perf: PR 7237

autowarefoundation#7237

* perf RP8406

autowarefoundation#8406

* perf PR 8416

* perf PR 8427

* perf PR 8413

* tool PR 8456

* perf PR 8461

* perf PR 8388

* perf PR 8467

* perf PR 8471

* perf PR 8490

* perf PR 8751

* chore: fix format

* perf PR 8657

* feat: improve lanelet search logic in getPredictedReferencePath()

* sp develop remove non approved change (#1611)

Revert "feat: improve lanelet search logic in getPredictedReferencePath()"

This reverts commit 5de95b0.

* feat PR 8811

* fix PR 8973

* feat: improve lanelet search logic in getPredictedReferencePath()

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
Co-authored-by: temkei.kem <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: danielsanchezaran <[email protected]>
Co-authored-by: mkquda <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants