revert: "feat(lane_departure_checker): add parameter of footprint_extra_margin" #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a_margin…" This reverts commit 0245366.
sfukuta
approved these changes
Oct 30, 2024
…ker/add_param_footprint_extra_margin
yn-mrse
deleted the
revert-1565-feat/lane_departure_checker/add_param_footprint_extra_margin
branch
|
1222-takeshi
added a commit
that referenced
this pull request
Nov 15, 2024
* fix spline bug Signed-off-by: Y.Hisaki <[email protected]> * revert: "feat: apply pose_instability_risk to localization_diag" (#1613) Revert "feat: apply pose_instability_risk to localization_diag (#1560)" This reverts commit 4bcb436. * revert: "feat(lane_departure_checker): add parameter of footprint_extra_margin" (#1614) Revert "feat(lane_departure_checker): add parameter of footprint_extra_margin…" This reverts commit 0245366. --------- Signed-off-by: Y.Hisaki <[email protected]> Co-authored-by: Y.Hisaki <[email protected]> Co-authored-by: Yuma Nihei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #1565
現時点、自己位置推定ずれ検出機能には「突然眼の前に発生した停止線」に対して自己位置推定のずれがなかった場合においても緊急停止してしまう問題がある。
この問題を孕んだ状態でリリースが難しいというプロジェクト判断により、v0.3.19としては自己位置推定ずれ検出機能のlaunch実装（起動設定及びMRM動作設定）を無効化し、次期リリースv0.3.20で正式にリリースする方針とする。
Related links
管理チケット
Tests performed
妥当性確認
githubのrevert機能を利用していることから、 Revert処理について自動化できているためヒューマンエラーの混入リスクを防止できている。
検証
他PR適用により削除されることが前提となるため、本PR単体としての機能変更の検証は不要と判断。
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.