Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system_monitor): add a hostname for diagnostic information #1636

Merged

Conversation

zhiwango
Copy link

@zhiwango zhiwango commented Nov 12, 2024

Description

This PR is used for pilot-auto.x2 after version beta/v3.1.0.
Because Autoware is running on main-ECU and sub-ECU, so we want to get their diagnostic information about the system monitor.
To confirm this information on the rqt-runtime-monitor, I add a hostname for diagnostic information.

Related links

Ticket

This is a related PR. https://github.com/tier4/autoware_launch.x2/pull/833

How was this PR tested?

I tested this PR on my local PC and J6 Bench.

Local PC

  • Main ECU hostname: DPC***
  • Sub ECU hostname: NPC***

Screenshot from 2024-11-11 17-10-34

J6 Bench 1.0

  • Main ECU hostname: autoware
  • Sub ECU hostname: sub

image

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

sonarcloud bot commented Nov 12, 2024

@zhiwango zhiwango marked this pull request as ready for review November 13, 2024 05:33
Copy link

@saka1-s saka1-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiwango zhiwango merged commit d7cc786 into beta/v0.29.0-1 Dec 2, 2024
25 of 26 checks passed
@zhiwango zhiwango deleted the feature/add-hostname-for-system-monitor-x2v310 branch December 2, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants