forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autonomous_emergency_braking): cherry pick/aeb latest to v4.0.0 #1643
Merged
TomohitoAndo
merged 29 commits into
beta/x2_gen2/v0.29.0
from
cherry-pick/aeb-latest-to-v4.0.0
Dec 13, 2024
Merged
feat(autonomous_emergency_braking): cherry pick/aeb latest to v4.0.0 #1643
TomohitoAndo
merged 29 commits into
beta/x2_gen2/v0.29.0
from
cherry-pick/aeb-latest-to-v4.0.0
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aeb (autowarefoundation#7548) * add polling sub to predicted objects Signed-off-by: Daniel Sanchez <[email protected]> * WIP requires changing path frame to map Signed-off-by: Daniel Sanchez <[email protected]> * add parameters and reuse predicted obj speed Signed-off-by: Daniel Sanchez <[email protected]> * introduce early break to reduce computation time Signed-off-by: Daniel Sanchez <[email protected]> * resolve merge conflicts Signed-off-by: Daniel Sanchez <[email protected]> * fix guard Signed-off-by: Daniel Sanchez <[email protected]> * remove unused declaration Signed-off-by: Daniel Sanchez <[email protected]> * fix include Signed-off-by: Daniel Sanchez <[email protected]> * fix include issues Signed-off-by: Daniel Sanchez <[email protected]> * remove inline Signed-off-by: Daniel Sanchez <[email protected]> * delete unused dependencies Signed-off-by: Daniel Sanchez <[email protected]> * add utils.cpp Signed-off-by: Daniel Sanchez <[email protected]> * remove _ for non member variable Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…utowarefoundation#7605) * add minimum cluster height threshold Signed-off-by: Daniel Sanchez <[email protected]> * add update param option Signed-off-by: Daniel Sanchez <[email protected]> * use param Signed-off-by: Daniel Sanchez <[email protected]> * avoid the float check if cluster_surpasses_threshold_height is already true Signed-off-by: Daniel Sanchez <[email protected]> * update README Signed-off-by: Daniel Sanchez <[email protected]> * add cluster height description Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…oundation#7740) change resize to reserve Signed-off-by: Daniel Sanchez <[email protected]>
…utowarefoundation#7707) * add support for negative speeds Signed-off-by: Daniel Sanchez <[email protected]> * remove negative speed check for predicted obj Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…utowarefoundation#7703) * apply clangd suggestions Signed-off-by: Daniel Sanchez <[email protected]> * add maintainer Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…owarefoundation#7894) * add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <[email protected]> * add maintainer Signed-off-by: Daniel Sanchez <[email protected]> * add uppercase Signed-off-by: Daniel Sanchez <[email protected]> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…state (autowarefoundation#8312) add info marker and override for state Signed-off-by: Daniel Sanchez <[email protected]>
…warefoundation#8330) update readme for new param Signed-off-by: Daniel Sanchez <[email protected]>
…undation#8126) * add initial tests Signed-off-by: Daniel Sanchez <[email protected]> * add more tests Signed-off-by: Daniel Sanchez <[email protected]> * more tests Signed-off-by: Daniel Sanchez <[email protected]> * WIP add publishing and test subscription Signed-off-by: Daniel Sanchez <[email protected]> * add more tests Signed-off-by: Daniel Sanchez <[email protected]> * fix lint cmake Signed-off-by: Daniel Sanchez <[email protected]> * WIP tf topic Signed-off-by: Daniel Sanchez <[email protected]> * Revert "WIP tf topic" This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <[email protected]> * add path crop test Signed-off-by: Daniel Sanchez <[email protected]> * add test for transform object Signed-off-by: Daniel Sanchez <[email protected]> * add briefs Signed-off-by: Daniel Sanchez <[email protected]> * delete repeated test Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…autowarefoundation#8569) * make it so AEB works with only one req path type (imu or MPC) Signed-off-by: Daniel Sanchez <[email protected]> * fix missing mpc path return Signed-off-by: Daniel Sanchez <[email protected]> * add check Signed-off-by: Daniel Sanchez <[email protected]> * modify no path msg Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…arefoundation#8611) fix bug by using the collision data keeper Signed-off-by: Daniel Sanchez <[email protected]>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <[email protected]> * update rss distance length Signed-off-by: Kyoichi Sugahara <[email protected]> --------- Signed-off-by: Kyoichi Sugahara <[email protected]>
…undation#8706) * add timekeeper to AEB Signed-off-by: Daniel Sanchez <[email protected]> * add more info to output Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…t transform (autowarefoundation#8734) set stamp to 0 to get the latest stamp instead of waiting for the stamp Signed-off-by: Daniel Sanchez <[email protected]>
…8778) * add missing rclcpp::Time(0) Signed-off-by: Daniel Sanchez <[email protected]> * refactor to reduce cropping to once per iteration Signed-off-by: Daniel Sanchez <[email protected]> * add LookUpTransform to utils Signed-off-by: Daniel Sanchez <[email protected]> * separate object creation and clustering Signed-off-by: Daniel Sanchez <[email protected]> * error handling of empty pointcloud Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…8789) align the control parameters Signed-off-by: Zhe Shen <[email protected]>
…ll polygons for debugging purposes (autowarefoundation#8865) * add markers showing aeb convex hull polygons for debugging purposes Signed-off-by: Daniel Sanchez <[email protected]> * fix briefs Signed-off-by: Daniel Sanchez <[email protected]> * fix typo Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
… localization is faulty (autowarefoundation#8873) make a clearer image for aeb when localization is faulty Signed-off-by: Daniel Sanchez <[email protected]>
…ndation#8930) make hull markers 3d Signed-off-by: Daniel Sanchez <[email protected]>
…owarefoundation#8950) add missing params Signed-off-by: Daniel Sanchez <[email protected]>
…n the search area (autowarefoundation#8591) * refactor PR Signed-off-by: ismetatabay <[email protected]> * WIP Signed-off-by: ismetatabay <[email protected]> * change using polygon to lateral offset Signed-off-by: ismetatabay <[email protected]> * improve code Signed-off-by: ismetatabay <[email protected]> * remove redundant code Signed-off-by: ismetatabay <[email protected]> * skip close points in MPC path generation Signed-off-by: ismetatabay <[email protected]> * fix empty path points in short parking scenario Signed-off-by: ismetatabay <[email protected]> * fix readme conflicts Signed-off-by: ismetatabay <[email protected]> --------- Signed-off-by: ismetatabay <[email protected]>
…ation#8998) add sanity chackes Signed-off-by: Daniel Sanchez <[email protected]>
…foundation#9004) * set a limit to the imu path length Signed-off-by: Daniel Sanchez <[email protected]> * fix test and add a new one Signed-off-by: Daniel Sanchez <[email protected]> * update readme Signed-off-by: Daniel Sanchez <[email protected]> * pre-commit Signed-off-by: Daniel Sanchez <[email protected]> * use velocity and time directly to get arc length Signed-off-by: Daniel Sanchez <[email protected]> * refactor to reduce repeated code Signed-off-by: Daniel Sanchez <[email protected]> * cleaning code Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…ublisher to virtual_wall_publisher (autowarefoundation#9078) Signed-off-by: kyoichi-sugahara <[email protected]>
… back distance usage (autowarefoundation#9141) * fix no backward imu path and wrong back distance usage Signed-off-by: Daniel Sanchez <[email protected]> * use the motion utils isDrivingForward function Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
…ndation#8789)" This reverts commit f35d4a3.
danielsanchezaran
requested review from
TakaHoribe,
takayuki5168 and
soblin
as code owners
November 14, 2024 02:06
github-actions
bot
added
type:ci
type:documentation
component:control
component:launch
labels
Nov 14, 2024
danielsanchezaran
changed the title
Cherry pick/aeb latest to v4.0.0
feat(autonomous_emergency_braking): cherry pick/aeb latest to v4.0.0
Nov 14, 2024
…arefoundation#9247) * solve issue with arc length Signed-off-by: Daniel Sanchez <[email protected]> * fix problem with points one vehicle apart from path Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
TomohitoAndo
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks to update AEB code. Requires launch updates too: https://github.com/tier4/autoware_launch.x2/pull/838
c033ce1 (HEAD -> cherry-pick/aeb-latest-to-v4.0.0, origin/cherry-pick/aeb-latest-to-v4.0.0) fix namespaces
755b016 fix(autonomous_emergency_braking): fix no backward imu path and wrong back distance usage (autowarefoundation#9141)
8c74d59 refactor(autoware_autonomous_emergency_braking): rename info_marker_publisher to virtual_wall_publisher (autowarefoundation#9078)
bead182 feat(autonomous_emergency_braking): set max imu path length (autowarefoundation#9004)
870b270 feat(autonomous_emergency_braking): add sanity chackes (autowarefoundation#8998)
4d446a2 feat(autonomous_emergency_braking): calculate the object's velocity in the search area (autowarefoundation#8591)
c472c3d docs(autonomous_emergency_braking): add missing params to README (autowarefoundation#8950)
37a2e8e feat(autonomous_emergency_braking): make hull markers 3d (autowarefoundation#8930)
cd97ade docs(autonomous_emergency_braking): make a clearer image for aeb when localization is faulty (autowarefoundation#8873)
64c7870 feat(autonomous_emergency_braking): add markers showing aeb convex hull polygons for debugging purposes (autowarefoundation#8865)
8d4f624 feat(autonomous_emergency_braking): speed up aeb (autowarefoundation#8778)
285a079 feat(autonomous_emergency_braking): increase aeb speed by getting last transform (autowarefoundation#8734)
87e56b2 feat(autonomous_emergency_braking): add timekeeper to AEB (autowarefoundation#8706)
d98b31b docs(autoware_autonomous_emergency_braking): improve AEB module's README (autowarefoundation#8612)
07ffb45 fix(autonomous_emergency_braking): fix debug marker visual bug (autowarefoundation#8611)
48ac496 feat(autonomous_emergency_braking): enable aeb with only one req path (autowarefoundation#8569)
20ed254 feat(autonomous_emergency_braking): add some tests to aeb (autowarefoundation#8126)
1ee945d docs(autonomous_emergency_braking): update readme for new param (autowarefoundation#8330)
36b06a5 feat(autonomous_emergency_braking): add info marker and override for state (autowarefoundation#8312)
594fc7b feat(autonomous_emergency_braking): add virtual stop wall to aeb (autowarefoundation#7894)
a195768 chore(autonomous_emergency_braking): apply clangd suggestions to aeb (autowarefoundation#7703)
03049a7 feat(autonomous_emergency_braking): aeb add support negative speeds (autowarefoundation#7707)
20ed254 feat(autonomous_emergency_braking): add some tests to aeb (autowarefoundation#8126)
1ee945d docs(autonomous_emergency_braking): update readme for new param (autowarefoundation#8330)
36b06a5 feat(autonomous_emergency_braking): add info marker and override for state (autowarefoundation#8312)
594fc7b feat(autonomous_emergency_braking): add virtual stop wall to aeb (autowarefoundation#7894)
a195768 chore(autonomous_emergency_braking): apply clangd suggestions to aeb (autowarefoundation#7703)
03049a7 feat(autonomous_emergency_braking): aeb add support negative speeds (autowarefoundation#7707)
cab9c6a fix(autonomous_emergency_braking): aeb strange mpc polygon (autowarefoundation#7740)
647d9d5 feat(autonomous_emergency_braking): add cluster min height for aeb (autowarefoundation#7605)
61d242d feat(autonomous_emergency_braking): add predicted object support for aeb (autowarefoundation#7548)
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.