Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert customize hazard status converter #1816

Closed
wants to merge 633 commits into from
Closed

Conversation

saka1-s
Copy link

@saka1-s saka1-s commented Feb 14, 2025

Description

Revert this PR because this change makes Rviz noisy.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

maxime-clem and others added 30 commits November 22, 2023 13:20
chore: sync beta branch beta/v0.17.0 with tier4/main
…foundation#5792)

1. The `updateData()` function now sets `status_.is_safe_dynamic_objects` to true when `requiresDynamicObjectsCollisionDetection()` returns false.

2. The `isExecutionReady()` function now checks for dynamic object collisions only if `requiresDynamicObjectsCollisionDetection()` returns true and `isWaitingApproval()` also returns true. This change ensures that dynamic object collision detection is performed only when necessary and approval is pending.

Signed-off-by: kyoichi-sugahara <[email protected]>
…dation#5782)

* feat(start_planner): add surround moving obstacle check
This commit introduces a new feature in the start_planner module for checking surrounding moving obstacles.
- It adds parameters to specify the search radius and threshold velocity for moving obstacles, along with flags to indicate which types of objects should be checked.
- The `noMovingObjectsAround` function has been added to filter dynamic objects within a certain radius based on their velocity.
  - If no moving objects are detected, the function returns true; otherwise, it returns false.
- This feature enhances the safety of the start_planner by ensuring that the path can't be approved while surrond moving obstacles exist.
---------
Signed-off-by: kyoichi-sugahara <[email protected]>
fix(start_planner): check safety only when waiting approval (autowarefoundation#5792)
…oid exceeding max voxel size (#1065)

fix(lidar_centerpoint,image_projection_based_fusion): add guard to avoid exceeding max voxel size (autowarefoundation#5824)

Co-authored-by: Daisuke Nishimatsu <[email protected]>
chore: sync beta branch beta/v0.18.0 with tier4/main
chore: sync beta branch beta/v0.19.0 with tier4/main
…warefoundation#6006)

* fix(static_drivable_area_expansion): fix bound extraction logic

Signed-off-by: satoshi-ota <[email protected]>

* refactor(static_drivable_area_expansion): define as anon func

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
…arefoundation#6017)

fix(avoidance): output return shift path properly

Signed-off-by: satoshi-ota <[email protected]>
…le (#1086)

feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <[email protected]>
… launch (#1088)

refactor(tier4_planning_launch): remove duplicate arguments in launchfile (autowarefoundation#6040)

Signed-off-by: Maxime CLEMENT <[email protected]>
…priority (autowarefoundation#6003)

* add explanation about start pose candidate priority

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
…finished (autowarefoundation#5998)

Fix conditional check in updatePullOutStatus function

Signed-off-by: kyoichi-sugahara <[email protected]>
…oundation#6002)

Update Start Planner module to stop in response to dynamic obstacles

Signed-off-by: kyoichi-sugahara <[email protected]>
…ndation#5983)

* refactor extractCollisionCheckPath

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
…oundation#5994)

* define collision check margins list in start planner module

Signed-off-by: kyoichi-sugahara <[email protected]>


---------

Signed-off-by: kyoichi-sugahara <[email protected]>
…dependencies (autowarefoundation#5909)

* change .hpp name

Signed-off-by: Zhe Shen <[email protected]>

* change .cpp name

Signed-off-by: Zhe Shen <[email protected]>

* correct the #inlcude and #ifndef

Signed-off-by: Zhe Shen <[email protected]>

* toPath(): move the prototypes and the implementations in .hpp and .cpp

Signed-off-by: Zhe Shen <[email protected]>

* correct the dependency for /home/shen/autoware.universe/planning/behavior_path_planner/src/behavior_path_planner_node.cpp

Signed-off-by: Zhe Shen <[email protected]>

* toPath(): deleted the repeat definition in planning_interface_test_manager_utils.hpp

Signed-off-by: Zhe Shen <[email protected]>

* toPath(): corrected the call and dependency in planning_interface_test_manager.cpp

Signed-off-by: Zhe Shen <[email protected]>

* convertPathToTrajectoryPoints(), convertTrajectoryPointsToPath(), lerpOrientation(): moved to conversion.hpp and conversion.cpp

Signed-off-by: Zhe Shen <[email protected]>

* convertPathToTrajectoryPoints(): corrected the call and dependency

Signed-off-by: Zhe Shen <[email protected]>

* convertTrajectoryPointsToPath(): Corrected the call

Signed-off-by: Zhe Shen <[email protected]>

* lerpOrientation(): deleted the repeat definition in longitudinal_controller_utils.hpp and longitudinal_controller_utils.cpp

Signed-off-by: Zhe Shen <[email protected]>

* lerpOrientation(): Correct the call in longitudinal_controller_utils.hpp

Signed-off-by: Zhe Shen <[email protected]>

* lerpOrientation(): Corrected the dependency and call in test_longitudinal_controller_utils.cpp

Signed-off-by: Zhe Shen <[email protected]>

* name of conversion.cpp: modified the CMakeLists

Signed-off-by: Zhe Shen <[email protected]>

* namespace updated, but maybe not correct, will be tested in the next commit

Signed-off-by: Zhe Shen <[email protected]>

* Correct the dependencies the test_trajectory.cpp and test_interpolation.cpp

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* [namespace problems fixed] conversion.cpp & conversion.hpp: The dependencies have been added. Also, the namespaces have been corrected.

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* correct all the dependencies in #include

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* avoid using the ../../ in the paths

Signed-off-by: Zhe Shen <[email protected]>

* dependencies fixed and package added in .xml

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* change toPath() to convertToPath()

Signed-off-by: Zhe Shen <[email protected]>

* lerpOrientation(): move from conversion to spherical_linear_interpolation

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* fix the missing relative path definition. ../../ will not be used.

Signed-off-by: Zhe Shen <[email protected]>

* the unneccessary dependencies eleminated. In specific, the lerpOrientation() related dependencies in coversion.hpp and unneccessary dependencies in conversion.cpp are deleted.

Signed-off-by: Zhe Shen <[email protected]>

* change the function to template in .cpp and .hpp

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* change the corresponding calls to template

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* change name to convertToTrajectory()

Signed-off-by: Zhe Shen <[email protected]>

* style(pre-commit): autofix

* change the template of convertToPathWithLaneId()

Signed-off-by: Zhe Shen <[email protected]>

* fix the dependencies

Signed-off-by: Zhe Shen <[email protected]>

* refactor(motion_utils): specialize class

Signed-off-by: satoshi-ota <[email protected]>

* fix(motion_utils): remove unnecessary header

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: satoshi-ota <[email protected]>
refactor(motion_utils): cherry picked from a merged PR
…owarefoundation#6034)

* fix(lane_change): check able to return to original lane in abort

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix cancel state

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* revert changes

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@saka1-s saka1-s closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.