Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): cherry-pick for CollisionCheckDebug #836

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

zulfaqar-azmi-t4
Copy link

Description

autowarefoundation#4749
autowarefoundation#4796
autowarefoundation#4797
autowarefoundation#4743
autowarefoundation#4798

Related links

Tests performed

Compile and run autoware

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

zulfaqar-azmi-t4 and others added 5 commits September 14, 2023 18:28
… debug (autowarefoundation#4749)

* refactor(behavior_path_planner): renaming and comment collision check debug

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
…refoundation#4797)

* refactor(behavior_path_planner): use function with color name

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/marker_utils/colors.hpp

Co-authored-by: Satoshi OTA <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
…utowarefoundation#4798)

* refactor(behavior_path_plannner): commonize collision check markers

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Update planning/behavior_path_planner/src/marker_utils/utils.cpp

Co-authored-by: Satoshi OTA <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
@kyoichi-sugahara
Copy link

@zulfaqar-azmi-t4
Did you check psim working?

ここに記載してあるもの (またはリファレンス走行に向けて別で入れたいもの)で、作業者が空欄のものは、各々こちらのブランチにPR出してもらうようお願いします。
単発PRで他とのコンフリクトも少ない、というようなものであればcherry-pick -> 直push でも問題ないです。
大きなIF変更の入ったPRとかでなければ動作確認は不要です。まとめてやります。
(かなり大規模変更ある場合は、Autoware起動するか、位の確認はお願いしたいです。)

@zulfaqar-azmi-t4
Copy link
Author

zulfaqar-azmi-t4 commented Sep 14, 2023

@kyoichi-sugahara
Yes, I have compiled, run autoware and confirmed that the debug marker works as expected.
But please perform the check as well to ensure that it also works in your environment.

@tkimura4
Copy link
Collaborator

tkimura4 commented Sep 14, 2023

@kyoichi-sugahara @zulfaqar-azmi-t4

Yes, I have compiled, run autoware and confirmed that the debug marker works as expected.

ここまでやっていただいているので、後はこちらでまとめて動作確認します!ありがとうございます。

@tkimura4 tkimura4 merged commit 86e14f9 into tmp/beta/v0.10.1 Sep 14, 2023
@tkimura4 tkimura4 deleted the temp-cherry-pick-for-debug branch September 14, 2023 15:09
@kyoichi-sugahara
Copy link

@zulfaqar-azmi-t4
Thank you so much for checking and doing this tasks!
I really appreciate it!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants