feat(ekf_localizer): ignore zero band #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(ekf_localizer): add diagnostics Signed-off-by: yamato-ando <Yamato ANDO> * update readme Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * update diag message Signed-off-by: yamato-ando <Yamato ANDO> * refactor Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * add OK message Signed-off-by: yamato-ando <Yamato ANDO> * fix typo Signed-off-by: yamato-ando <Yamato ANDO> * fix typo Signed-off-by: yamato-ando <Yamato ANDO> * Update localization/ekf_localizer/src/diagnostics.cpp Co-authored-by: Kento Yabuuchi <[email protected]> --------- Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kento Yabuuchi <[email protected]>
…ndation#5042) * feat(ekf_localizer): ignore dead band of velocity sensor Signed-off-by: kminoda <[email protected]> * update Signed-off-by: kminoda <[email protected]> * update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update stop_filter as well Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-actions
bot
added
documentation
kminoda
changed the title
…ation#5066) * fix(ekf_localizer): fix bug in autowarefoundation#5054 Signed-off-by: kminoda <[email protected]> * fix bug Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]>
|
@YamatoAndo これApproveお願いします！（実車で確認済み） |
kminoda
requested review from
Motsu-san,
YamatoAndo,
TakaHoribe and
IshitaTakeshi
as code owners
YamatoAndo
approved these changes
Sep 22, 2023
|
@kminoda すぐ言えることは，一見どんなPRかわからないです。decriptionを修正してください。 |
|
@kminoda
|
|
@Motsu-san 確認ありがとうございます。2点とも確認し、descriptionに追記しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X2での２段階停止対策PRです。
9/21-22における実機実験で、上記PRにより2段階停止がなくなること、またPRをrevertすることで逆に2段階停止が再現することから、本PRによって解決すると判断。