Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): rearrange downsample #870

Closed
wants to merge 2 commits into from

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Sep 25, 2023

Description

This PR will move voxel_grid_downsample pointcloud from before compare_map_filter to before ground_segmentation to reduce computational cost.
https://star4.slack.com/archives/C03S84LDJGG/p1695623101952399?thread_ts=1695301059.965649&cid=C03S84LDJGG

Related link

This PR should merge together with tier4/aip_launcher#175

Tests performed

Reduce 6% of cpu usage of /pointcloud_container

Before After
0388f3fc-7d88-4520-b78f-b90befa92094_2023-10-06-10-12-41_p0900_before_arrange_max_53%_min_41%.webm 0388f3fc-7d88-4520-b78f-b90befa92094_2023-10-06-10-12-41_p0900_after_arrange_voxel_grid_downsample_max_45%_min_36.7%_add_param_voxel_size.webm

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <[email protected]>
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen
Copy link
Author

@miursh I reflected your comment tier4/aip_launcher#175 (comment) in bc48f9e. Could you review this again?

@badai-nguyen
Copy link
Author

@miursh

  • As our discustion, to keep keep pointcloud coordinates unchanged after downsampling, the approximate_downsample_filter should be used.
  • However, there was no improvement in computational cost (total CPU usage% of pointcloud_container) so I will close this PR.

Comparison of CPU% of pointcloud_container using rosbag 0388f3fc-7d88-4520-b78f-b90befa92094_2023-09-26-10-54-08_p0900_1.

before-rearrange after-rearrange voxelgridbased after-rearrange approximate
before-rearrange_CPU-Percent after-rearrange-voxelgridbased_CPU-Percent after-rearrange-approximatedownsample_CPU-Percent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants