Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): organize input twist topic (#5125) #889

Conversation

kminoda
Copy link

@kminoda kminoda commented Sep 28, 2023

Fix a bug in concatenate_filter.

Cherry-picked from: autowarefoundation#5125
To address: https://tier4.atlassian.net/browse/RT0-29158
Which is validated in: https://tier4.atlassian.net/wiki/spaces/MiS/pages/2881388553

…ndation#5125)

* fix(pointcloud_preprocessor): organize input twist topic (#25)

* fix(pointcloud_preprocessor): organize input twist topic

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* fix build bug

Signed-off-by: kminoda <[email protected]>

* fix format error

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* fix

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* minor fixes

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* add warning

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation launch sensing labels Sep 28, 2023
@kminoda kminoda marked this pull request as ready for review September 28, 2023 09:30
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit af72ece into tier4:beta/v0.11.0 Sep 29, 2023
12 checks passed
@kminoda kminoda deleted the fix/pointcloud_preprocessor/organize_twist_in_concatenate_filter branch June 20, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch sensing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants