Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ml model path #890

Merged
merged 8 commits into from
Sep 29, 2023
Merged

fix: ml model path #890

merged 8 commits into from
Sep 29, 2023

Conversation

miursh
Copy link

@miursh miursh commented Sep 28, 2023

Description

Hotfix: Fix model paths used in ML packages

Related links

cherry-pick PRs below
autowarefoundation#5069
autowarefoundation#5118
autowarefoundation#5119
autowarefoundation#5141
autowarefoundation#5144
autowarefoundation#5158
autowarefoundation#5162
autowarefoundation#5163

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

lexavtanke and others added 8 commits September 28, 2023 22:39
…warefoundation#5069)

* feat(perception_launch): add var data_path to perception.launch

Signed-off-by: Alexey Panferov <[email protected]>

* feat(perception_launch): update default center_point_model_path

Signed-off-by: Alexey Panferov <[email protected]>

---------

Signed-off-by: Alexey Panferov <[email protected]>
…t model path (autowarefoundation#5118)

* fix(traffic_light_fine_detector): add data_path arg and update default model path

Signed-off-by: Alexey Panferov <[email protected]>

* fix(traffic_light_fine_detector): update README with data path arg

Signed-off-by: Alexey Panferov <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Alexey Panferov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…utowarefoundation#5119)

* fix(tensorrt_yolox): add data_path arg and update default model path

Signed-off-by: Alexey Panferov <[email protected]>

* fix(tensorrt_yolox): update README

Signed-off-by: Alexey Panferov <[email protected]>

---------

Signed-off-by: Alexey Panferov <[email protected]>
… file path (autowarefoundation#5141)

* fix(traffic_light_ssd_fine_detector): add arg data_path, update model file path 

Signed-off-by: Alexey Panferov <[email protected]>

* fix(traffic_light_ssd_fine_detector): update README with data_path arg

Signed-off-by: Alexey Panferov <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Alexey Panferov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…utowarefoundation#5144)

* fix(traffic_light_classfier): add arg data_path, update model path

Signed-off-by: Alexey Panferov <[email protected]>

* fix(traffic_light_classifier): add arg data_path, update model path

Signed-off-by: Alexey Panferov <[email protected]>

* fix(traffic_light_classifier): add arg data_path to README

Signed-off-by: Alexey Panferov <[email protected]>

---------

Signed-off-by: Alexey Panferov <[email protected]>
* fix(tensorrt_yolo): add arg data_path, update onnx_file

Signed-off-by: Alexey Panferov <[email protected]>

* fix(tensorrt_yolo): update model downloading in README, add data_path

Signed-off-by: Alexey Panferov <[email protected]>

---------

Signed-off-by: Alexey Panferov <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation launch perception labels Sep 28, 2023
@miursh miursh marked this pull request as ready for review September 28, 2023 14:21
@miursh miursh requested review from TakaHoribe and tkimura4 and removed request for manato, knzo25, yukkysaito, YoshiRi, yukke42, wep21, tzhong518 and dan-dnn September 28, 2023 14:21
@wep21 wep21 changed the title Fix/centerpoint model path fix: change model paths used in ml package Sep 28, 2023
@miursh miursh changed the title fix: change model paths used in ml package fix: ml model path Sep 28, 2023
@wep21 wep21 self-requested a review September 28, 2023 14:28
@miursh miursh merged commit cb19d15 into beta/v0.13.0 Sep 29, 2023
21 of 26 checks passed
@miursh miursh deleted the fix/centerpoint_model_path branch September 29, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch perception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants