fix(lane_change): cherry pick lane change PRs for x2 #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
purewater0901
as code owners
zulfaqar-azmi-t4
changed the title
zulfaqar-azmi-t4
force-pushed
the
cp-lane-change-x2
branch
2 times, most recently
from
4305f0b to
5405655
Compare
* fix(lane_change): fix target object filter Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * used lateral distance from centerline instead Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]>
…#5083) * fix(lane_change): object filter other lane object Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * remove accidentally added code Signed-off-by: Zulfaqar Azmi <[email protected]> * fix some missing code Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]>
…anes (autowarefoundation#5135) * feat(behavior_path_planner): lane change collided polygon intersect lanes Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use wrapper instead of std::optional Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * rearrange code Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Revert "chore: add workaround for tf2 update (autowarefoundation#5127)" This reverts commit 19ab508. * fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs Signed-off-by: wep21 <[email protected]> * revet change for local build Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: wep21 <[email protected]> Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: wep21 <[email protected]> Co-authored-by: kyoichi-sugahara <[email protected]>
…foundation#5167) * feat(lane_change): expand target lanes for object filtering Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use expanded target lanes in collision check Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
…refoundation#5214) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
cp-lane-change-x2
branch
from
5405655 to
89fff0b
Compare
…utowarefoundation#5246) Signed-off-by: Zulfaqar Azmi <[email protected]>
takayuki5168
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking lane change commits.
Related links
fix(lane_change): fix target object filter #4930
fix(lane_change): object filter other lane object #5083
feat(lane_change): expand target lanes for object filtering #5167
feat(behavior_path_planner): lane change collided polygon intersect lanes #5135
feat(lane_change): object filter visualization #5082
fix(lane_change): current lane obj treated as target lane obj #5214
feat(lane_change): separate execution and cancel safety check param #5246
THIS LAUNCHER IS NEEDED (https://github.com/tier4/autoware_launch.x2/pull/465)
cap-.2023-10-02-15-14-54.mp4
Tests performed
Compile with planning simulator
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.