fix: crosswalk pedestrian lights #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n light to CIRCLE (autowarefoundation#5168) Signed-off-by: Tomohito Ando <[email protected]>
…ion#5169) Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
requested review from
satoshi-ota,
shmpwk,
takayuki5168 and
tkimura4
as code owners
TomohitoAndo
changed the title
takayuki5168
approved these changes
Oct 4, 2023
t4-x2
pushed a commit
that referenced
this pull request
Oct 5, 2023
* fix(crosswalk_traffic_light_estimator): change the shape of pedestrian light to CIRCLE (autowarefoundation#5168) Signed-off-by: Tomohito Ando <[email protected]> * fix(crosswalk): check all elements in traffic signal (autowarefoundation#5169) Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cherry-pick following PRs
This fixes the bug that crosswalk module doesn't ignore the red pedestrian light.
Related ticket:
TEIR IV INTERNAL
Tests performed
See autowarefoundation#5169
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.