Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): make switchable detection by tracker in x2 project #964

Merged

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Oct 19, 2023

Description

As described in awf PR autowarefoundation#5313, this PR aiming to turn off detection_by_tracker to lower computation burden in X2 sihojiri.

Set use_detection_by_tracker to false if you want skip the process/

Tests performed

Check node diagram in Lsim.

Discussed in Ticket.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen
Copy link

IMO use_detection_by_tracker also need to be add here?


-> <group if="$(var use_detection_by_tracker)">

and here


-> <group if="$(var use_detection_by_tracker)">

since it also becomes unnecessary when detection_by_tracker is disable.
BTW, we can fix it in another PR

@YoshiRi
Copy link
Author

YoshiRi commented Oct 20, 2023

@badai-nguyen
You are right. I fixed it in 2ab407d.

@takayuki5168 takayuki5168 merged commit 33dbaa4 into tier4:beta/v0.11.0 Oct 22, 2023
10 checks passed
@YoshiRi YoshiRi deleted the feat/make_switchable_dbt_in_x2 branch October 23, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants