Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception): add iou x and change the points_num of the validator #990

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

Shin-kyoto
Copy link

@Shin-kyoto Shin-kyoto commented Oct 25, 2023

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…or to be set class by class (autowarefoundation#5177)

* fix: add param for each object class

Signed-off-by: badai-nguyen <[email protected]>

* fix: add missing classes param

Signed-off-by: badai-nguyen <[email protected]>

* fix: launch file

Signed-off-by: badai-nguyen <[email protected]>

* fix: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactor

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
@shmpwk
Copy link
Collaborator

shmpwk commented Oct 25, 2023

@Shin-kyoto It looks no commit for autowarefoundation#5148 ?

…oi_cluster_fusion (autowarefoundation#5148)

* fix: add iou_x for long range obj

Signed-off-by: badai-nguyen <[email protected]>

* fix: add launch file param

Signed-off-by: badai-nguyen <[email protected]>

* chore: fix unexpect calc iou in long range

Signed-off-by: badai-nguyen <[email protected]>

* fix: multi iou usable

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* docs: update readme

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactor

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 26, 2023
@Shin-kyoto
Copy link
Author

@Shin-kyoto It looks no commit for autowarefoundation#5148 ?

That is because we talked about the parameter in that PR here, but now I understood that reason, so I add the change for autowarefoundation#5148.

@Shin-kyoto Shin-kyoto changed the base branch from beta/v0.10.3 to beta/v0.10.4 October 27, 2023 06:03
@Shin-kyoto Shin-kyoto marked this pull request as ready for review October 27, 2023 06:04
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shin-kyoto Shin-kyoto merged commit f9edab3 into beta/v0.10.4 Nov 2, 2023
23 checks passed
@Shin-kyoto Shin-kyoto deleted the feat/perception/add-iou_x-and-validation branch November 2, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch perception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants