Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): 信号連携周りの改善 #997

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

soblin
Copy link

@soblin soblin commented Oct 31, 2023

Description

取り込み元

対応するlauncher PR: https://github.com/tier4/autoware_launch.xx1/pull/688

LSIM結果は
https://github.com/tier4/autoware_launch.xx1/pull/688
に貼った動画を参照

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

takayuki5168 and others added 2 commits November 2, 2023 14:19
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
autowarefoundation#5304)

* merge attention area lanelets topologically

Signed-off-by: Mamoru Sobue <[email protected]>

* query stop line for each merged detection lanelet

Signed-off-by: Mamoru Sobue <[email protected]>

* first conflicting/attention area

Signed-off-by: Mamoru Sobue <[email protected]>

* ignore expectedToStopBeforeStopLine vehicle

Signed-off-by: Mamoru Sobue <[email protected]>

* ignore expectedToStopBeforeStopLine vehicle

Signed-off-by: Mamoru Sobue <[email protected]>

* fix

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the hotfix/intersection branch from dcb0be2 to ec7efe2 Compare November 2, 2023 10:00
@soblin soblin marked this pull request as ready for review November 2, 2023 10:01
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkimura4 tkimura4 merged commit 25bd248 into beta/v0.10.4 Nov 2, 2023
16 of 17 checks passed
@tkimura4 tkimura4 deleted the hotfix/intersection branch November 2, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants