chore(histogram): display number for Y-axis instead of probability #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: takeshi.iwanari <[email protected]>
iwatake2222
changed the title
Signed-off-by: takeshi.iwanari <[email protected]>
|
👍 |
iwatake2222
deleted the
chore_histogram_use_number_instead_of_probability
branch
5 tasks
xygyo77
pushed a commit
to xygyo77/caret_analyze
that referenced
this pull request
Nov 17, 2023
…ier4#430) * chore(histogram): display number instead of probability Signed-off-by: takeshi.iwanari <[email protected]> * fix: change hover label Signed-off-by: takeshi.iwanari <[email protected]> --------- Signed-off-by: takeshi.iwanari <[email protected]>
5 tasks
xygyo77
added a commit
that referenced
this pull request
Dec 11, 2023
* create_response_time_timeseries_plot() API for sim_time. Signed-off-by: ISP akm <[email protected]> * Add support sim_time to histogram APIs. Signed-off-by: ISP akm <[email protected]> * fix: unified graph captions. (#410) * Unified graph captions. Signed-off-by: emb4 <[email protected]> * Unified conditional branching of graph captions. Signed-off-by: emb4 <[email protected]> * Fixed flake8 errors. Signed-off-by: emb4 <[email protected]> * Point corrected. Signed-off-by: emb4 <[email protected]> * Corrected string notation. Signed-off-by: emb4 <[email protected]> * Corrected string notation. Signed-off-by: emb4 <[email protected]> * Corrected the points pointed out. Signed-off-by: emb4 <[email protected]> * Corrected caption. Signed-off-by: emb4 <[email protected]> * Corrected caption. Signed-off-by: emb4 <[email protected]> --------- Signed-off-by: emb4 <[email protected]> * chore(histogram): display number for Y-axis instead of probability (#430) * chore(histogram): display number instead of probability Signed-off-by: takeshi.iwanari <[email protected]> * fix: change hover label Signed-off-by: takeshi.iwanari <[email protected]> --------- Signed-off-by: takeshi.iwanari <[email protected]> * Add sim_time support to create_response_time_stacked_bar_plot() API Signed-off-by: ISP akm <[email protected]> * Histogram legends click policy is set to "hide" Signed-off-by: ISP akm <[email protected]> * Skip invalid records that are involved in sim_time conversion but are invalid. Signed-off-by: ISP akm <[email protected]> * ci(pre-commit): autofix * chore: spell miss coverter->converter Signed-off-by: ISP akm <[email protected]> * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * ci(pre-commit): autofix * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * ci(pre-commit): autofix * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * fixed pytest errors Signed-off-by: ISP akm <[email protected]> * add test codes Signed-off-by: ISP akm <[email protected]> * Reflection of PR comments (Part 1) Signed-off-by: ISP akm <[email protected]> * spelling convert->round_convert Signed-off-by: ISP akm <[email protected]> * Supported removal of _convert_timeseries_records_to_sim_time(). Signed-off-by: ISP akm <[email protected]> * ci(pre-commit): autofix * Add sim_time support to StackedBarPlot.to_dataframe. Signed-off-by: ISP akm <[email protected]> * Fixed pytest error. Signed-off-by: ISP akm <[email protected]> * Fixed pytest error. Signed-off-by: ISP akm <[email protected]> * Fixed pytest error. Signed-off-by: ISP akm <[email protected]> * Reflection of PR comments (Part 2) Signed-off-by: ISP akm <[email protected]> * Reflection of PR comments (Part 3) Signed-off-by: ISP akm <[email protected]> --------- Signed-off-by: ISP akm <[email protected]> Signed-off-by: emb4 <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: emori-ctc <[email protected]> Co-authored-by: iwatake <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
isp-uetsuki
added a commit
to isp-uetsuki/CARET_analyze
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why this change is needed
Probabilityfor Y-axis. However,Probability(density=True) calculated by numpy.histogram is a little confusing. According to the reference,the sum of the histogram values will not be equal to 1 unless bins of unity width are chosen. So in our usage, the sum doesn't become 1. We can see the trend of Histogram but Y-axis value itself is uselessBefore
After
Related links
None
Notes for reviewers
ProbabilityPre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.