-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception): enable to specify region
filter.
#68
Conversation
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the distance from the center is always positive, it is possible to get the lower upper by splitting a string like 0.0-18.0 with -.
But with postion, aren't there also negative values?
For example, if it is -1.0-18.0, it is difficult to handle because there are multiple hyphens.
Other than that, I didn't see anything else that bothered me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specification role is that lower_limit and upper_limit are combined by , while Distance is combined by -.
I had missed it.
@hayato-m126 And, I wait for releasing autoware_perception_evaluation which related PR to pass ci/cd. |
Signed-off-by: MasatoSaeki <[email protected]>
718d088
to
a8fec35
Compare
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: Hayato Mizushima <[email protected]>
chore: update use case format version
The reason why colcon test is failing is because the main branch of perception_eval does not contain the update corresponding to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Types of PR
Description
This PR enables to specify
region
based on x-y coordinate from ego, and you can still usedistance
filter.Interface roles
Distance
orRegion
lower_limit
andupper_limit
are combined by,
whileDistance
is combined by-
.lower_limit
andupper_limit
ofx_position
ory_position
if useRegion
.How to review this PR
Fundamentally, follow this docs
assume that you have already done build of Autoware. To use branch is below.
feat/limitation_by_area
feat/limitation_by_area
You can specify
region
like belowOthers
region
autoware_perception_evaluation#200