Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne): remove unused large variable/copy #103

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 4, 2023

PR Type

  • Bug Fix

Related Links

None.

Description

Entire Velodyne scan was copied into an unused variable. This PR removes the variable.

Hopefully the compiler already optimizes this out but just to be sure, it's better to remove it.

Review Procedure

  • Check if it compiles
  • Check if variable is really unused?

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@mojomex mojomex self-requested a review December 5, 2023 03:13
@mojomex mojomex changed the title fix: remove unused large variable/copy fix(velodyne): remove unused large variable/copy Dec 5, 2023
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mojomex mojomex merged commit 16f2817 into tier4:main Dec 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants