fix(robosense): use correct field to check time sync status

[mebasoglu]

PR Type

• Bug Fix

Related Links

Description

Currently, to get the time synchronization status, wrong field is used. If the sensor doesn't have time synchronization, driver doesn't start.

The current checked field is time_sync_mode states the mode that was set on web interface such as GPS or PTP.

This PR fixes this issue by checking sync_status field which is the correct way to see time synchronization status.

Review Procedure

You can use pcap files to test: #77 (comment)

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov-commenter]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (810849e) 6.43% compared to head (a3da6b8) 11.30%.

Files	Patch %	Lines
...s/nebula_decoders_robosense/decoders/bpearl_v3.hpp	0.00%	3 Missing ⚠️
...s/nebula_decoders_robosense/decoders/bpearl_v4.hpp	0.00%	3 Missing ⚠️
...ders/nebula_decoders_robosense/decoders/helios.hpp	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            main     #106      +/-   ##
=========================================
+ Coverage   6.43%   11.30%   +4.87%     
=========================================
  Files        136       60      -76     
  Lines      10895     5537    -5358     
  Branches     854      799      -55     
=========================================
- Hits         701      626      -75     
+ Misses      9618     4357    -5261     
+ Partials     576      554      -22     

Flag	Coverage Δ
differential	11.30% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mojomex]

Thank you for the PR, good catch!
Everything looks good and I confirmed it is working as expected using the PCAPs for unsynced and GPS sync, as well as our Bpearl v4 for gPTP, PTP-E2E-L2, PTP-E2E-L2 and PTP-P2P.

Spell check is complaining about the word manc, so could you add it to .cspell.json to make CI pass?

[mojomex]

LGTM!