Skip to content

Commit

Permalink
fix typo
Browse files Browse the repository at this point in the history
  • Loading branch information
Bodong-Yang committed Apr 25, 2024
1 parent 192e36b commit d157e60
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions otaclient/app/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def subprocess_check_output(
Args:
cmd (str | list[str]): command to be executed.
raise_exception (bool, optional): raise the underlaying CalledProcessError. Defaults to False.
default (str, optional): if <raise_exception> is False, return <default> on underlaying
raise_exception (bool, optional): raise the underlying CalledProcessError. Defaults to False.
default (str, optional): if <raise_exception> is False, return <default> on underlying
subprocess call failed. Defaults to "".
timeout (Optional[float], optional): timeout for execution. Defaults to None.
Expand Down Expand Up @@ -197,7 +197,7 @@ def subprocess_call(
Args:
cmd (str | list[str]): command to be executed.
raise_exception (bool, optional): raise the underlaying CalledProcessError. Defaults to False.
raise_exception (bool, optional): raise the underlying CalledProcessError. Defaults to False.
timeout (Optional[float], optional): timeout for execution. Defaults to None.
"""
try:
Expand Down Expand Up @@ -563,7 +563,7 @@ def shutdown(self, *, raise_last_exc: bool):
logger.debug("shutdown retry task map")
if self._running_inst:
self._running_inst.shutdown(raise_last_exc=raise_last_exc)
# NOTE: passthrough the exception from underlaying running_inst
# NOTE: passthrough the exception from underlying running_inst
finally:
self._running_inst = None
self._executor.shutdown(wait=True)
Expand Down
2 changes: 1 addition & 1 deletion otaclient/app/proto/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ After the compiled python code is ready, we can define the wrappers accordingly
# type hints for each attributes when manually create instances
# of wrapper types.
# NOTE: this __init__ is just for typing use, it will not be
# used by the underlaying MessageWrapper
# used by the underlying MessageWrapper
# NOTE: if pyi file is also generated when compiling the proto file,
# the __init__ in pyi file can be used directly with little adjustment
def __init__(
Expand Down

0 comments on commit d157e60

Please sign in to comment.