Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image path #269

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix: image path #269

merged 1 commit into from
Dec 26, 2023

Conversation

obi-t4
Copy link
Contributor

@obi-t4 obi-t4 commented Dec 26, 2023

Description

This PR fixes build-external bash script to handle arbitrary directory.

Check list

  • test file that covers the bug case(s) is implemented.
  • local test is passed.

Bug fix

Current behavior

Current implementation can't handle arbitrary rootfs image directory.

Behaivor after fix

This PR fixes this issue.

Related links & ticket

@obi-t4 obi-t4 added the bug Something isn't working label Dec 26, 2023
@Bodong-Yang Bodong-Yang self-requested a review December 26, 2023 07:11
@Bodong-Yang Bodong-Yang added chore Pull requests that do not relate to a fix or feature and don't modify source code(like tagging, etc) tools labels Dec 26, 2023
@Bodong-Yang Bodong-Yang enabled auto-merge (squash) December 26, 2023 07:13
@Bodong-Yang Bodong-Yang disabled auto-merge December 26, 2023 07:13
Copy link
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
otaclient/app
   common.py2681594%55, 185, 200, 275–277, 287, 296–298, 404, 416, 504, 535, 539
   configs.py100100% 
   copy_tree.py80396%42, 93, 122
   downloader.py2634483%68, 81–82, 297, 302, 306, 324–325, 375–379, 398–400, 403–404, 407–408, 429–432, 436–437, 441–442, 446–447, 456, 531–533, 549, 569–571, 575, 577, 580, 585–587
   ecu_info.py59788%76–77, 90, 95, 118–119, 128
   errors.py1130100% 
   interface.py50100% 
   log_setting.py26773%27–28, 59, 61–63, 69
   main.py42490%48–49, 64, 67
   ota_client.py37613065%52–53, 73, 175–176, 189, 192, 196, 199, 238–241, 253–256, 259–260, 264–269, 279–282, 326–329, 334, 338, 341, 354–357, 360–367, 370–377, 383–386, 413, 416–417, 419, 422–425, 427–428, 433–434, 437, 451–458, 465, 468–474, 521–524, 535, 571, 576–579, 584–586, 589–590, 592–593, 595–596, 598, 659–660, 663, 671, 675, 678, 689–690, 693, 701, 705, 708, 719, 738, 749–750, 767, 786, 790–791, 806
   ota_client_call.py40685%44–46, 82–84
   ota_client_service.py39587%60–61, 72–74
   ota_client_stub.py39410872%78–80, 82–83, 91, 94–96, 99–101, 105–107, 109–110, 113–116, 118, 121–122, 125–127, 132–137, 141, 144–148, 150–151, 159–161, 164, 206–208, 213, 248, 273, 276, 279, 383, 409, 411, 437, 487, 549, 619–620, 659, 679–681, 687–690, 694–696, 703–705, 708, 712–715, 772, 859–861, 868, 898–899, 902–906, 915–924, 931, 937, 940–941, 945, 948
   ota_metadata.py3153190%145, 150, 186–187, 197–198, 201, 213, 271, 304–306, 323–326, 406, 409, 417–419, 432, 441–442, 445–446, 719–720, 723, 727, 730
   ota_status.py14285%33, 41
   proxy_info.py47589%79, 81, 84, 119, 126
   update_stats.py105298%160, 170
otaclient/app/boot_control
   __init__.py40100% 
   _cboot.py29314251%80–84, 86–88, 97–100, 102–104, 108, 110, 116–117, 119, 123, 130, 134, 138, 142–146, 150–154, 161–163, 167–169, 172–173, 176–177, 179, 181–183, 186–190, 193–197, 201, 206–210, 213, 215–216, 219, 225, 228, 231, 234, 237, 240, 243, 246–247, 250–251, 254, 256–258, 261–262, 277, 280, 320, 334–337, 350–353, 363–364, 366, 374, 413, 430–433, 442–445, 450–452, 461, 463–464, 466–467, 470, 477, 507–510, 544–547, 552–554, 559–563, 568–574
   _common.py37014860%64–66, 68–70, 72–73, 82–83, 87–88, 96–97, 108–109, 114–119, 124–129, 138, 147, 151, 155, 159, 173–174, 176, 186–188, 190, 195, 199, 209–211, 213, 221–222, 230–231, 233, 244–248, 252–256, 268–270, 282–284, 295–296, 299–303, 306, 308–309, 319–323, 327–331, 333–340, 359, 363, 366, 375, 392, 395, 401–403, 411–417, 512, 517, 522, 581–582, 636, 640–641, 644, 652, 654–655, 711–712, 715, 729, 734–735, 737, 745, 748, 751–753, 756, 765, 825–828, 849–852, 868–869, 878
   _errors.py471959%43–46, 50–52, 59–67, 69, 89–90
   _grub.py40511471%216, 264–267, 273–277, 314–315, 322–327, 330, 332, 335–337, 342, 344–346, 355–357, 359–361, 370–372, 374–376, 455–456, 460–461, 513, 519, 545, 564, 568–569, 584–586, 617, 621–623, 625–627, 682, 685–688, 707–710, 735–738, 768–771, 813, 819, 839–840, 842, 854, 857, 860, 863, 867–869, 887–890, 912–915, 920–928, 933–941
   _rpi_boot.py27212554%84–86, 92–93, 95, 98, 101, 104, 109, 117–118, 120, 126, 130–133, 138–140, 144–147, 172–174, 180–182, 197–199, 205–207, 221–228, 230, 234, 238–239, 243–246, 249–250, 255, 259, 263, 267, 301, 331, 334–336, 344, 353–356, 366–369, 373–380, 424–426, 471, 474–477, 494–497, 502, 505, 526–529, 534–542, 547–555, 569–572, 578–580, 583
   configs.py106595%57–58, 177, 256, 276
   firmware.py31583%60, 62, 73–75
   protocol.py40100% 
   selecter.py382728%42–44, 46, 49–50, 52–54, 57, 59, 64–66, 74–76, 78–79, 81–83, 85–87, 89, 91
otaclient/app/create_standby
   __init__.py12558%29–31, 33, 35
   common.py2179257%73, 76–77, 81–83, 85, 87–89, 92, 94, 142, 153, 190–192, 194–196, 198, 201–204, 208, 219, 292–294, 296–301, 303–313, 316–320, 322, 325, 347–348, 352, 356–357, 360–362, 368–369, 373, 375–380, 385–388, 392–393, 397, 405–408, 410, 415–417, 419, 422–423, 425, 431–432
   interface.py60100% 
   rebuild_mode.py98792%82, 84, 95–97, 102, 129
otaclient/app/proto
   __init__.py31390%37, 44–45
   _common.py4074788%85, 163, 170, 182–184, 203, 208, 219, 256, 262, 267, 298, 302, 306, 403, 464, 471, 474, 494, 501, 503, 529, 535, 538, 540, 565, 571, 574, 576, 605, 609, 611, 625, 642, 670, 673, 677, 680, 708, 714, 761–764, 766, 797
   _ota_metafiles_wrapper.py841680%36–42, 112–116, 122–125
   _otaclient_v2_pb2_wrapper.py2663786%87, 90–93, 132, 175, 183, 197, 207, 210–211, 213, 258, 261, 264–265, 285, 305, 385, 452, 505, 513–515, 519–520, 522, 525–526, 529–530, 551, 559, 573, 581, 595
   streamer.py43881%32, 47, 65–66, 71, 80–81, 99
   wrapper.py40100% 
otaclient/ota_proxy
   __init__.py31680%58–59, 61, 70, 79–80
   _consts.py150100% 
   cache_control.py68494%71, 91, 113, 121
   config.py180100% 
   db.py1461589%75, 81, 103, 113, 116, 145–147, 166, 199, 208–209, 229, 258, 300
   errors.py100100% 
   orm.py1131091%91, 96, 101, 107, 113, 140–141, 154, 231, 235
   ota_cache.py4048878%95–96, 215, 226, 253–255, 275, 291–292, 294, 317–318, 324, 328, 330, 359–363, 379, 440–441, 483–484, 554, 567–570, 620, 639–640, 672–673, 684, 718–722, 726–728, 730, 732–739, 741–743, 746–747, 751–752, 756, 803, 811–813, 892–895, 899, 902–903, 917–918, 920–922, 926–927, 933–934, 965, 971, 998, 1027–1029
   server_app.py1383971%75, 78, 84, 100, 102, 161, 170, 212–213, 215–217, 220, 225–227, 230–231, 234, 237, 240, 243, 256–257, 260–261, 263, 266, 292–295, 298, 312–314, 320–322
   utils.py23195%31
TOTAL5900133277% 

Tests Skipped Failures Errors Time
172 0 💤 0 ❌ 0 🔥 5m 0s ⏱️

@obi-t4 obi-t4 merged commit 2542c9b into main Dec 26, 2023
3 checks passed
@obi-t4 obi-t4 deleted the fix/image-path branch December 26, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests that do not relate to a fix or feature and don't modify source code(like tagging, etc) tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants