fix(v3.6.x): persists file handling should be at PROCESS_POSTUPDATE phase

[Bodong-Yang]

Description

By design the persist file handling stage should be in PROCESS_POSTUPDATE phase.

However due to when migrating from old implementation, persist file handling is still implemented as part of create_standby mechanism. In newer otaclient, the create_standby stage is counted as APPLY_UPDATE phase, resulting in mismatch with design and implementation.

In real world condition, this mismatch might cause the following behavior in APPLY_UPDATE phase:

1. all files are processed, but no progress is made and phase is still stuck at APPLY_UPDATE phase,
2. if persist file handling also copying the swapfile(this is improper, it will be handled in another PR), APPLY_UPDATE will be stuck with even longer time.

This PR fixes the issue by move persist file handling out of create_standby package, and implements it in PROCESS_POSTUPDATE phase.

Check list

• local test is passed.
• vm test is passed.

Bug fix

Behaivor after fix

1. now APPLY_UPDATE phase should be finished immediately after all files for new slot are created and processed,
2. persist file handling now is included in PROCESS_POSTUPDATE phase.

Related links & ticket

RT4-8805

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
otaclient/app
__init__.py	0	0	100%
__main__.py	3	3	0%	16–19
common.py	268	14	95%	55, 185, 200, 275–277, 287, 296–298, 404, 416, 535–539
configs.py	76	0	100%
copy_tree.py	81	3	96%	45, 96, 125
downloader.py	271	44	84%	70, 83–84, 299, 304, 308, 326–327, 377–381, 400–410, 431–449, 458, 533–535, 551, 571–589
ecu_info.py	59	7	88%	78–79, 92, 97, 120–121, 130
errors.py	113	0	100%
interface.py	17	4	76%	32, 43, 47, 51
log_setting.py	26	7	73%	27–28, 55–65
main.py	31	2	94%	43–44
ota_client.py	386	139	64%	51–52, 74, 180–204, 241–244, 256–272, 282–285, 291–313, 355–358, 363–370, 383–406, 412–415, 444–468, 482–489, 496, 499–505, 552–555, 563, 599, 604–626, 687–703, 714–730, 741, 760, 771–772, 789, 808, 812–813, 828
ota_client_call.py	38	6	84%	42–44, 80–82
ota_client_service.py	29	3	90%	58–60
ota_client_stub.py	395	108	73%	79–84, 92–102, 106–128, 133–142, 145–152, 160–165, 207–209, 214, 249, 274, 277, 280, 384, 410, 412, 438, 488, 550, 620–621, 660, 680–691, 695–709, 713–716, 775, 862–871, 901–948, 951
ota_metadata.py	315	31	90%	147, 152, 188–189, 199–203, 215, 273, 306–308, 325–328, 408, 411, 419–421, 434, 443–448, 721–732
ota_status.py	15	2	87%	36, 44
proxy_info.py	51	7	86%	82–87, 122–129, 137–138
update_stats.py	105	2	98%	162, 172
otaclient/app/boot_control
__init__.py	4	0	100%
_cboot.py	288	142	51%	82–90, 99–112, 118–121, 125, 132, 136, 140, 144–148, 152–156, 163–175, 178–221, 227, 230, 233, 236, 239, 242, 245, 248–249, 252–253, 256–260, 263–264, 279, 282, 316, 333–336, 349–352, 362–365, 373, 412, 429–432, 441–444, 449–451, 460–466, 469, 476, 506–509, 548–551, 556–567, 572–578
_common.py	369	143	61%	65–74, 83–84, 88–89, 97–98, 109–110, 115–120, 125–130, 139, 148, 152, 156, 160, 174–177, 187–191, 196, 200, 210–214, 222–234, 245–249, 253–257, 269–271, 283–285, 296–310, 320–341, 360–376, 393–404, 412–418, 513–523, 582–583, 637, 641–642, 645, 653–656, 712–713, 716, 730–738, 753–754, 828–831, 852–855, 868–869, 878
_errors.py	47	19	60%	43–69, 89–90
_grub.py	403	114	72%	217, 265–268, 274–278, 315–316, 323–347, 356–362, 371–377, 456–462, 514, 520, 546, 568–573, 588–590, 619–629, 684–690, 709–712, 737–740, 763–766, 808, 814, 834–837, 849, 852, 855, 858, 862–864, 882–885, 913–916, 921–929, 934–942
_rpi_boot.py	266	125	53%	85–87, 93–148, 172–174, 180–182, 195–197, 203–205, 218–243, 248, 252, 256, 260, 294, 324, 327–329, 337, 346–349, 359–362, 366–373, 413–415, 457–461, 480–483, 488, 491, 512–515, 520–528, 533–541, 555–558, 564–566, 569
configs.py	58	2	97%	46–47
firmware.py	32	5	84%	63, 65, 76–78
protocol.py	28	5	82%	53, 57, 61, 65, 73
selecter.py	39	27	31%	45–69, 77–94
otaclient/app/create_standby
__init__.py	12	5	58%	30–36
common.py	216	45	79%	74, 77–78, 82–95, 141, 189–197, 200–203, 207, 218, 292–300, 312, 356–361, 377–378, 392–396, 421–422
interface.py	19	3	84%	55, 59, 63
rebuild_mode.py	89	1	99%	106
otaclient/app/proto
__init__.py	31	3	90%	37, 44–45
_common.py	419	49	88%	85, 163, 170, 182–184, 203, 208, 219, 256, 262, 267, 298, 302, 306, 363, 380, 403, 464, 471, 474, 494, 501, 503, 529, 535, 538, 540, 565, 571, 574, 576, 605, 609, 611, 625, 642, 670, 673, 677, 680, 708, 714, 761–766, 797
_ota_metafiles_wrapper.py	84	13	85%	37, 40–42, 112–116, 122–125
_otaclient_v2_pb2_wrapper.py	276	37	87%	87, 90–93, 132, 175, 183, 197, 207, 210–213, 258, 261, 264–265, 285, 305, 385, 452, 505, 513–515, 519–522, 525–530, 551, 559, 573, 581, 595
streamer.py	43	8	81%	32, 47, 65–66, 71, 80–81, 99
wrapper.py	4	0	100%
otaclient/ota_proxy
__init__.py	46	3	93%	86, 90, 94
__main__.py	22	22	0%	16–79
_consts.py	15	0	100%
cache_control.py	68	4	94%	71, 91, 113, 121
config.py	18	0	100%
db.py	146	15	90%	75, 81, 103, 113–116, 145–147, 166, 199, 208–209, 229, 258, 300
errors.py	10	0	100%
orm.py	115	11	90%	37, 91, 96, 101, 107, 113, 140–141, 154, 231, 235
ota_cache.py	404	75	81%	95–96, 215, 226, 253–255, 275, 291–294, 317–330, 359–363, 379, 440–441, 483–484, 554, 567–570, 620, 639–640, 672–673, 684, 721–728, 735–736, 741–743, 747, 756, 803, 811–813, 892–895, 899–903, 917–934, 965, 971, 998, 1027–1029
server_app.py	138	39	72%	75, 78, 84, 100, 102, 161–170, 212–243, 256–266, 292–298, 312–314, 320–322
utils.py	23	1	96%	31
TOTAL	6011	1298	78%