-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v3.6.x): properly handling swapfile during persist file handling #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodong-Yang
force-pushed
the
fix/swapfile
branch
from
March 4, 2024 03:25
d46a7ff
to
a34580b
Compare
Bodong-Yang
changed the title
fix: properly handling swapfile during persist file handling
fix(v3.6.x): properly handling swapfile during persist file handling
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the proper way to create swapfile, and provides a workaround fix in persist file handling to handle swapfile creating.
At the time when persist file mechanism design was proposed by the original developer, handling swapfile was not considered but is wildly used in real world to create swapfile in new slot.
By default direct copy is used to persist file from active slot to standby slot, however for swapfile, direct copy is improper(see https://wiki.archlinux.org/title/swap for the proper way of creating a swapfile) and will cost unnecessary time if the swapfile is huge.
Note
In the upcoming new OTA image spec, we will no-longer handle swapfile in persist file handling hook, but handle it at dedicated hook.
Check list
Bug fix
Behaivor after fix
Related links & ticket
RT4-8553