-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve the performance of active slot scanning #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
Bodong-Yang
added
the
refactor
Rewrite/remove related code instead of patching them
label
May 30, 2024
2 tasks
Bodong-Yang
added a commit
that referenced
this pull request
Jun 24, 2024
…mit pending tasks in memory (#320) In #308 , the active slot scanning is improved by waiting for all tasks instead of waiting for each folder being scanned, but this brings an issue that if the files processing speed is not fast enough, the pending tasks will pile up. This PR implements the limitation of total ongoing files scanning entries, and define the number of thread workers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the following refinement to speed up the active slot scanning during delta_calculating and preparing:
executor.shutdown(wait=True)
to wait, this will saving lots of memory and speed up the overall progress.Check list
Test result
The test is executed by update the VM from same image to same image, maximize the re-usable delta.
Used image: https://evaluation.ci.dev.tier4.jp/evaluation/vehicle_catalogs/8cbe2292-5300-4762-8f25-0d53501986a9/firmware_releases/4bbb9de1-c8ab-4d9a-ae39-8eaab2758c29?project_id=tier4_demo.
with this PR(otaclient is manually installed.)
During the active slot scanning and delta calculation, the memory usage is stable around 280MB.
with v3.7.1
During the active slot scanning and delta calculation, the memory usage is around 350MB, with up and down.
Changes
Behavior changes
Does this PR introduce behavior change(s)?
Breaking change
Does this PR introduce breaking change?
Related links & tickets