-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: project restruct phase2 #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Bodong-Yang
added
the
refactor
Rewrite/remove related code instead of patching them
label
Jun 3, 2024
for more information, see https://pre-commit.ci
Bodong-Yang
added a commit
that referenced
this pull request
Jun 5, 2024
commit bfa3bb5 Author: Bodong Yang <[email protected]> Date: Wed Jun 5 19:16:32 2024 +0900 refactor: project restruct phase2 (#311) Project restruct phase2, in this phase most of the changes are restructring the packages to make the project more modularized and decoupling each components as much as possible. 1. ota_metadata becomes a standalone package, current implementation is treated as the implementation for OTA image format legacy version. 2. create new otaclient_api, current version is v2 and all the protobuf pb2 generated code and proto wrappers are grouped under v2. 3. create new otaclient_common, all common shared libs, helper funcs and types are grouped under this package, categorized by functionality. 4. fix according to import paths changes. 5. restruct tests according to the new project layout. 1. cleanup bootstrap, refactor into samples, which provide sample ecu_info.yaml, proxy_info.yaml and otaclient.service for single ECU setup. 2. fix up tools/offline_ota_image_builder and status_monitor package. 3. not use relative imports anymore. commit 9f975ad Author: Bodong Yang <[email protected]> Date: Tue Jun 4 17:12:05 2024 +0900 chore(tools): remove out-of-date unmaintained tools (#313) This PR removes the unmaintained old tools, including tools.emulator, tools.test_utils and tools/build_image.sh. commit 0ce3cc9 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Jun 4 16:32:45 2024 +0900 [pre-commit.ci] pre-commit autoupdate (#312) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/tox-dev/pyproject-fmt: 1.8.0 → 2.1.3](tox-dev/pyproject-fmt@1.8.0...2.1.3) - [github.com/igorshubovych/markdownlint-cli: v0.40.0 → v0.41.0](igorshubovych/markdownlint-cli@v0.40.0...v0.41.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Project restruct phase2, in this phase most of the changes are restructring the packages to make the project more modularized and decoupling each components as much as possible.
Major changes
The following changes are applied:
ota_metadata
becomes a standalone package, current implementation is treated as the implementation for OTA image formatlegacy
version.otaclient_api
, current version isv2
and all the protobuf pb2 generated code and proto wrappers are grouped underv2
.otaclient_common
, all common shared libs, helper funcs and types are grouped under this package, categorized by functionality.Other changes
bootstrap
, refactor intosamples
, which provide sampleecu_info.yaml
,proxy_info.yaml
andotaclient.service
for single ECU setup.tools/offline_ota_image_builder
andstatus_monitor
package.Tests
Tests are executed on VM(x86_64 with grub).