-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create otaclient_common._io module for holding io related helper funcs #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file_digest func
Bodong-Yang
added
the
refactor
Rewrite/remove related code instead of patching them
label
Oct 10, 2024
Bodong-Yang
changed the title
feat: create otaclient_common._io module for holding io related helper funcs
refactor: create otaclient_common._io module for holding io related helper funcs
Oct 10, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR introduces a new module
otaclient_common._io
for holding io related helper functions with refinement.Especially, this modules provides the following new features/changes:
cal_file_digest
helper function, based on python stdlib file_digest.write_str_to_file_atomic
method, replacing the oldwrite_str_to_file
, which uses the rename syscall to atomically update target file. This function is intended for writing critical config files like boot cfg files, and it is much robust to unexpected interruption, ensured by kernel rename syscall.symlink_atomic
func.copyfile_atomic
func.Tests